Validation of FrameworkTypesReturn for @BINDS. Fixes #24

src/main/kotlin/com/madrapps/dagger/validation/BindsProblem.kt

@@ -39,6 +39,7 @@ object BindsProblem : Problem {
             this += method.validateMultipleScope(range, "@Binds methods cannot use more than one @Scope %s")
             this += method.validateMultipleQualifier(range, "@Binds methods may not use more than one @Qualifier %s")
             this += method.validateVoidReturn(range, "@Binds methods must return a value (not void)")
+            this += method.validateFrameworkTypesReturn(range, "@Binds methods must not return framework types %s")
         }
     }
 }

src/test/testData/binds/FrameworkTypeReturn/FrameworkTypes.java

@@ -0,0 +1,40 @@
+import javax.inject.Inject;
+import dagger.Module;
+import dagger.Provides;
+import dagger.Binds;
+import assets.Car;
+import assets.CarImpl;
+import dagger.Lazy;
+import dagger.MembersInjector;
+import javax.inject.Provider;
+
+@Module
+public abstract class FrameworkTypes {
+
+    @<error descr="@Binds methods must not return framework types [Lazy]">Binds</error>
+    public abstract Lazy lazyReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [Lazy]">Binds</error>
+    public abstract Lazy<?> lazyWildReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [Lazy]">Binds</error>
+    public abstract Lazy<Car> lazyWrappedReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [Provider]">Binds</error>
+    public abstract Provider providerReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [Provider]">Binds</error>
+    public abstract Provider<?> providerWildReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [Provider]">Binds</error>
+    public abstract Provider<Car> providerWrappedReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [MembersInjector]">Binds</error>
+    public abstract MembersInjector membersInjectorReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [MembersInjector]">Binds</error>
+    public abstract MembersInjector<?> membersInjectorWildReturn(CarImpl car);
+
+    @<error descr="@Binds methods must not return framework types [MembersInjector]">Binds</error>
+    public abstract MembersInjector<Car> membersInjectorWrappedReturn(CarImpl car);
+}

src/test/testData/binds/FrameworkTypeReturn/KFailureComponent.kt

@@ -0,0 +1,31 @@
+import javax.inject.Inject
+import dagger.Module
+import dagger.Provides
+import dagger.Binds
+import assets.Car
+import assets.CarImpl
+import dagger.Lazy
+import dagger.MembersInjector
+import javax.inject.Provider
+
+@Module
+abstract class KFrameworkTypes {
+
+    @<error descr="@Binds methods must not return framework types [Lazy]">Binds</error>
+    abstract fun lazyWildReturn(car: CarImpl): Lazy<*>
+
+    @<error descr="@Binds methods must not return framework types [Lazy]">Binds</error>
+    abstract fun lazyWrappedReturn(car: CarImpl): Lazy<Car>
+
+    @<error descr="@Binds methods must not return framework types [Provider]">Binds</error>
+    abstract fun providerWildReturn(car: CarImpl): Provider<*>
+
+    @<error descr="@Binds methods must not return framework types [Provider]">Binds</error>
+    abstract fun providerWrappedReturn(car: CarImpl): Provider<Car>
+
+    @<error descr="@Binds methods must not return framework types [MembersInjector]">Binds</error>
+    abstract fun membersInjectorWildReturn(car: CarImpl): MembersInjector<*>
+
+    @<error descr="@Binds methods must not return framework types [MembersInjector]">Binds</error>
+    abstract fun membersInjectorWrappedReturn(car: CarImpl): MembersInjector<Car>
+}

src/test/testData/binds/FrameworkTypeReturn/KSuccessComponent.kt

@@ -0,0 +1,31 @@
+import javax.inject.Inject
+import dagger.Module
+import dagger.Provides
+import dagger.Binds
+import assets.Car
+import assets.CarImpl
+import dagger.Lazy
+import dagger.MembersInjector
+import javax.inject.Provider
+
+@Module
+abstract class KWrappedFrameworkTypes {
+
+    @Binds
+    abstract fun lazyWildReturn(car: CarImpl): Set<Lazy<*>>
+
+    @Binds
+    abstract fun lazyWrappedReturn(car: CarImpl): Set<Lazy<Car>>
+
+    @Binds
+    abstract fun providerWildReturn(car: CarImpl): Set<Provider<*>>
+
+    @Binds
+    abstract fun providerWrappedReturn(car: CarImpl): Set<Provider<Car>>
+
+    @Binds
+    abstract fun membersInjectorWildReturn(car: CarImpl): Set<MembersInjector<*>>
+
+    @Binds
+    abstract fun membersInjectorWrappedReturn(car: CarImpl): Set<MembersInjector<Car>>
+}

src/test/testData/binds/FrameworkTypeReturn/WrappedFrameworkTypes.java

@@ -0,0 +1,41 @@
+import javax.inject.Inject;
+import dagger.Module;
+import dagger.Provides;
+import dagger.Binds;
+import assets.Car;
+import assets.CarImpl;
+import dagger.Lazy;
+import dagger.MembersInjector;
+import javax.inject.Provider;
+import java.util.Set;
+
+@Module
+public abstract class WrappedFrameworkTypes {
+
+    @Binds
+    public abstract Set<Lazy> lazyReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<Lazy<?>> lazyWildReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<Lazy<Car>> lazyWrappedReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<Provider> providerReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<Provider<?>> providerWildReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<Provider<Car>> providerWrappedReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<MembersInjector> membersInjectorReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<MembersInjector<?>> membersInjectorWildReturn(CarImpl car);
+
+    @Binds
+    public abstract Set<MembersInjector<Car>> membersInjectorWrappedReturn(CarImpl car);
+}