Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pool connection is released in acquire when cancelled #548

Closed
wants to merge 5 commits into from
Closed

Ensure pool connection is released in acquire when cancelled #548

wants to merge 5 commits into from

Commits on Mar 28, 2020

  1. Ensure pool connection is released in acquire when cancelled 

    Closes MagicStack#547

When wait_for is cancelled, there is a chance that the waited
task has already been completed, leaving the connection
looking like it is in use. This fix ensures that the connection
is returned to the pool in this situation.

For context, see:
https://bugs.python.org/issue37658
MagicStack#467
    @aaliddell
    aaliddell committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    20511f8 View commit details
    Browse the repository at this point in the history

  2. Update other use of wait_for workaround 

    Added issue link and comment describing why this workaround
is necessary. Also moved the function to be local to the
call site, as it it not used elsewhere.
    @aaliddell
    aaliddell committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    2646c81 View commit details
    Browse the repository at this point in the history

  3. Add test for acquire connection leak

    @aaliddell
    aaliddell committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    6f22ad8 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Use asyncio.wait_for in pool acquire regardless of timeout 

    When wait_for is called with timeout=None, it runs without
a timeout, as desired
    @aaliddell
    aaliddell committed May 2, 2020
    Configuration menu
    Copy the full SHA
    51b8d7c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Merge branch 'master' into pool-acquire-leak

    @aaliddell
    aaliddell authored May 5, 2020
    Configuration menu
    Copy the full SHA
    b95f99f View commit details
    Browse the repository at this point in the history