-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace _PyLong_Format
with PyNumber_ToBase
#118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_PyLong_Format` is in Python’s internal, private API; `PyNumber_ToBase` belongs to the Stable API, and is a fairly thin wrapper around `_PyLong_Format` with a bit of extra error checking. Fixes MagicStack#116.
musicinmybrain
force-pushed
the
python3.13
branch
from
June 5, 2024 16:42
69e2be3
to
851c4e9
Compare
hswong3i
added a commit
to alvistack/MagicStack-immutables
that referenced
this pull request
Jun 13, 2024
git clean -xdf tar zcvf ../python-immutables_0.20.orig.tar.gz --exclude=.git . debuild -uc -us cp python-immutables.spec ../python-immutables_0.20-1.spec cp ../python*-immutables*0.20*.{gz,xz,spec,dsc} /osc/home\:alvistack/MagicStack-immutables-0.20/ rm -rf ../python*-immutables*0.20*.* See MagicStack#118 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Python 3.13 is out, and
I maintain a package that relies on immutables, and this is keeping my package from working with Py3.13. |
For the benefit of anyone else seeing this, this command will get a working immutables in place on 3.13 as a stopgap: pip install "git+https://github.com/musicinmybrain/[email protected]#egg=immutables" |
1st1
approved these changes
Oct 9, 2024
cc @fantix |
fantix
added a commit
that referenced
this pull request
Oct 10, 2024
Changes ======= * Drop typing_extensions dependency (#114) (by @nicoddemus in 3ba46f7 for #114) Fixes ===== * Replace `_PyLong_Format` with `PyNumber_ToBase` (#118) (by @musicinmybrain in 81d7c92 for #116)
Merged
Thank you very much, also for rolling a new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_PyLong_Format
is in Python’s internal, private API;PyNumber_ToBase
belongs to the Stable API, and is a fairly thin wrapper around_PyLong_Format
with a bit of extra error checking.Fixes #116.