feat: refactor the code for the tokens page and adapt the style to the latest design draft #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteMinds
requested review from
Daryl-L,
Keith-CY,
PainterPuppets and
FrederLu
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…e latest design draft
WhiteMinds
force-pushed
the
feat/523_InscriptionsPageMobileStyles
branch
from
7e71862
to
69da391
Compare
Keith-CY
approved these changes
Feb 1, 2024
Daryl-L
reviewed
Feb 1, 2024
| @@ -4,15 +4,17 @@ import styles from './Card.module.scss' | |||
|
|
|||
| export interface CardProps extends ComponentProps<'div'> { | |||
| rounded?: boolean | 'top' | 'bottom' | |||
| shadow?: boolean | |||
There was a problem hiding this comment.
It is ambiguous I think, because there is another meaning for shadow, boxShadow instead maybe better.
There was a problem hiding this comment.
I'm not quite sure what you mean by the other meaning of shadow?
In my opinion, shadow referring to box-shadow is a common implementation, as seen in Tailwind CSS as well.
However, the meaning of the shadow property here is not entirely about box-shadow, it just indicates whether to enable shadow for the card, box-shadow is just one of the implementation details inside the component.
Daryl-L
approved these changes
Feb 1, 2024
FrederLu
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: Magickbase/ckb-explorer-public-issues#523
Mainly modified the desktop and mobile styles of the list header and list items on this page.