feat: support cell data decoding #267
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const DECODER = { | ||
| utf8: 'UTF-8', | ||
| number: 'Number', | ||
| // todo: support decode address & Big-Endian |
There was a problem hiding this comment.
| // todo: support decode address & Big-Endian | |
| // todo: support decode address & Little-Endian & JSON string |
There was a problem hiding this comment.
Here I have a bit of a question, what should be the decode rule for address? Is hex used as a public key and then parse to address or what does it mean?
And are the rules for decoding json different from utf-8?
There was a problem hiding this comment.
I think parsing address into a script is pretty enough
src/pages/Transaction/TransactionCellScript/CellInfoDataView.tsx
Outdated
Show resolved
Hide resolved
|
Updated. Support for Witness and adding more parsing methods will be further upgraded in the other pr |
|
Conflicted |
PainterPuppets
force-pushed
the
cell_data_support_decoding
branch
from
c8055ae
to
b647542
Compare
|
Resloved |
| @@ -0,0 +1,87 @@ | |||
| import { useMemo, useRef, useState } from 'react' | |||
| import { Select } from 'antd' | |||
There was a problem hiding this comment.
It's better not to use antd because it's hard to customize
|
While checking address detail page, it shows like this |
Crashed on page https://ckb-explorer-frontend-in-magickbase-repo-git-f721c2-magickbase.vercel.app/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq063fpg7044e42s7xqnyrm5yrp6lmsfjdq47y03k please have a check @PainterPuppets |
|
https://ckb-explorer-frontend-in-magickbase-repo-2es2w4zo8-magickbase.vercel.app/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqtyy4lspd4k86v8vz06n03dpjrdx5gzp7cxulwv8 |
Checked and found that it's not caused by this pr, I'll follow up on this issue in other pr |
Caused by Magickbase/ckb-explorer-public-issues#580, a PR to improve the compatibility will be added to the develop branch |
src/pages/Transaction/TransactionCellScript/CellInfoDataView.tsx
Outdated
Show resolved
Hide resolved
src/pages/Transaction/TransactionCellScript/CellInfoDataView.tsx
Outdated
Show resolved
Hide resolved
PainterPuppets
force-pushed
the
cell_data_support_decoding
branch
from
e7a54c8
to
d241c91
Compare
|
Changed the decode window to the global, I tried it myself and felt it was fine, but it feels like may need to test more into whether it will lead to a less experience in any areas |
Hot zone could be marked to trigger this popover, I'll propose a PR to this branch |
There was a problem hiding this comment.
Are these update still necessary when the selection is listened globally
There was a problem hiding this comment.
These code is to make the component look the same as the design, I'll remove it if our plan to update it later.
|
Hold on because a quick/simple implementation(nervosnetwork@4710e4c) was proposed to cater for recent projects |
Maybe this pr can be close? |
reslove: Magickbase/ckb-explorer-public-issues#331