Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add molecule parser tools #339

Merged
merged 4 commits into from
May 26, 2024
Merged

feat: add molecule parser tools #339

merged 4 commits into from
May 26, 2024

Conversation

PainterPuppets
Copy link

@PainterPuppets PainterPuppets commented May 19, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented May 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 7:17am

Keith-CY
Keith-CY reviewed May 21, 2024
View reviewed changes
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/ui/Alert.tsx Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

Keith-CY commented May 21, 2024 •
edited
Loading

IMO, mentioning built-in schemas next to the title Input schema(mol) makes it outstanding.

Found a relative design in the PRD
image

I was confused by inputting the option ScriptOpt (Script); and getting an error Duplicate name: ScriptOpt until I read the

we have added blockchain.mol as built-in schemas to this tool.

@Keith-CY
Copy link
Member

The built-in schema could be parsed and the first item could be active by default

image

@PainterPuppets PainterPuppets linked an issue May 23, 2024 that may be closed by this pull request
Tools Page Support Molecule Parser Magickbase/ckb-explorer-public-issues#660
Closed
@Keith-CY
Copy link
Member

The built-in schema could be parsed and the first item could be active by default

image

Any update on this suggestion?

@Keith-CY
Copy link
Member

The suggestion above will be implemented in another PR

@Keith-CY Keith-CY merged commit d516a96 into Magickbase:develop May 26, 2024
3 checks passed
@PainterPuppets
Copy link
Author

The built-in schema could be parsed and the first item could be active by default
image

Any update on this suggestion?

Just saw that, it be implemented at these lines

https://github.com/Magickbase/ckb-explorer-frontend/pull/339/files#diff-51e3a32fe74b2924baa18f7966fb3867256d844a53c58339ffb037301f220b28R17-R20

@Keith-CY
Copy link
Member

The built-in schema could be parsed and the first item could be active by default
image

Any update on this suggestion?

Just saw that, it be implemented at these lines

#339 (files)

Got it, I will update it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura left review comments

@Keith-CY Keith-CY Keith-CY approved these changes

@Daryl-L Daryl-L Awaiting requested review from Daryl-L

@Danie0918 Danie0918 Awaiting requested review from Danie0918

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tools Page Support Molecule Parser
3 participants
@PainterPuppets @Keith-CY @homura