Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block detail page support node-connect mode #390

Merged
merged 3 commits into from
Jul 2, 2024
Merged

feat: block detail page support node-connect mode #390

merged 3 commits into from
Jul 2, 2024

Conversation

PainterPuppets
Copy link

@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 4:59am

This was referenced Jun 27, 2024
Merged
Closed
@FrederLu
Copy link

FrederLu commented Jun 28, 2024 •
edited
Loading

Home page：
image

Block list：
image

Block detail page:
image

Compared with the latest block on the home page, when opening Node, it is found that Block detail page and Block list have not updated data. If Block detail page updates data, Block Height data should be updated, and the button on the right can switch to the latest block height data.

@PainterPuppets
Copy link
Author

Home page： image

Block list： image

Block detail page: image

Compared with the latest block on the home page, when opening Node, it is found that Block detail page and Block list have not updated data. If Block detail page updates data, Block Height data should be updated, and the button on the right can switch to the latest block height data.

  1. There is no way to sort the block on node rpc, just can only fetch the lastest few blocks, so the block list page doesn't use the node data.

  2. block detail page: fixed

@Keith-CY Keith-CY merged commit b1a1a08 into Magickbase:develop Jul 2, 2024
3 checks passed
Daryl-L pushed a commit that referenced this pull request Jul 2, 2024
@PainterPuppets @Daryl-L
feat: block detail page support node-connect mode (#390)
54c310c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@FrederLu FrederLu FrederLu approved these changes

@Daryl-L Daryl-L Awaiting requested review from Daryl-L

@Sven-TBD Sven-TBD Awaiting requested review from Sven-TBD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support node-connection mode
3 participants
@PainterPuppets @FrederLu @Keith-CY