Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Data sorting filtering #8

Merged
merged 46 commits into from
Aug 24, 2023
Merged

feat: Data sorting filtering #8

merged 46 commits into from
Aug 24, 2023

Conversation

pygman
Copy link

@pygman pygman commented May 29, 2023

Issue: Magickbase/ckb-explorer-public-issues#42

Frontend Issue: Magickbase/ckb-explorer-public-issues#244


Address page

Block Page

Block List Page

Transaction List Page

Token List Page

NFT Collection List Page

Token Page

NFT Page

Nervos DAO Page

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 6:48pm

src/locales/en.json Outdated Show resolved Hide resolved
src/components/NftHolderList/index.tsx Outdated Show resolved Hide resolved
src/pages/Address/AddressComp.tsx Outdated Show resolved Hide resolved
src/pages/BlockDetail/BlockComp.tsx Outdated Show resolved Hide resolved
src/pages/BlockDetail/BlockComp.tsx Outdated Show resolved Hide resolved
src/pages/BlockList/index.tsx Show resolved Hide resolved
src/pages/BlockList/index.tsx Show resolved Hide resolved
src/utils/hook.ts Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

Placeholder on depositors page has been fixed by 9d65c1e

image

Layout of transaction title on block detail page has been fixed by 66cfb57
image

Highilght of order buttons has been fixed by
block list page: ece7f02
tx list page: 1dc4ac0

image
image

Layout of order buttons on tokens page has been fixed by e1987ad

image


Creted time 1970-01-01 is exceptional data and should be fixed

cc @FrederLu @rabbitz

@FrederLu
Copy link

NFT Page
https://ckb-explorer-h9t3kthu1-magickbase.vercel.app/nft-collections/0x951dd6704ef1bac2fe1ab347d39d8f65a3b48dc75fe3cdc983aeaefd1bfa3467?tab=transfers
image
@rabbitz In the api, the information in the tx_hash field needs to be added.
Magickbase/ckb-explorer-public-issues#244 (comment)

Token List Page
When the Token List Page is sorted in descending order by Created Time, the creation time of the first three pieces of data does not seem to meet the conditions.
https://ckb-explorer-h9t3kthu1-magickbase.vercel.app/tokens?sort=created_time.desc
image

Except for the above two issues in the current PR, the other issues have been verified.
cc @Keith-CY @rabbitz

@rabbitz
Copy link

rabbitz commented Aug 18, 2023

  1. The udt create_time is empty because the value is block timestamp, but timestamp is a field added later. Currently testnet and mainnet have been fixed.

  2. Added filtering parameter tx_hash to nft collection transfers, related pr: chore: filter token transfers with tx_hash nervosnetwork/ckb-explorer#1392

@FrederLu
Copy link

NFT Page
https://ckb-explorer-zle5itckm-magickbase.vercel.app/nft-collections/0x951dd6704ef1bac2fe1ab347d39d8f65a3b48dc75fe3cdc983aeaefd1bfa3467?tab=transfers&filter=ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqgdqd5qds6ytcwydyxt2arh55yr6x6w69qtwrwg8
Request URL: https://ckb-explorer-api.staging.layerview.io//api/v2/nft/transfers?page=1&collection_id=0x951dd6704ef1bac2fe1ab347d39d8f65a3b48dc75fe3cdc983aeaefd1bfa3467&address_hash=ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqgdqd5qds6ytcwydyxt2arh55yr6x6w69qtwrwg8

image

@Keith-CY
It is now possible to use hash search in the NFT page, but the page data using address (from/to) is not processed, and the expected data cannot be obtained.

@Keith-CY
Copy link
Member

NFT Page ckb-explorer-zle5itckm-magickbase.vercel.app/nft-collections/0x951dd6704ef1bac2fe1ab347d39d8f65a3b48dc75fe3cdc983aeaefd1bfa3467?tab=transfers&filter=ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqgdqd5qds6ytcwydyxt2arh55yr6x6w69qtwrwg8 Request URL: https://ckb-explorer-api.staging.layerview.io//api/v2/nft/transfers?page=1&collection_id=0x951dd6704ef1bac2fe1ab347d39d8f65a3b48dc75fe3cdc983aeaefd1bfa3467&address_hash=ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqgdqd5qds6ytcwydyxt2arh55yr6x6w69qtwrwg8

image @Keith-CY It is now possible to use hash search in the NFT page, but the page data using address (from/to) is not processed, and the expected data cannot be obtained.

Please have a check @rabbitz

@rabbitz
Copy link

rabbitz commented Aug 24, 2023

nft transfers filter by address hash related pr: nervosnetwork/ckb-explorer@df8a607

@Keith-CY Keith-CY merged commit cddb837 into develop Aug 24, 2023
5 checks passed
@Keith-CY Keith-CY deleted the data-sorting-filtering branch August 24, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants