Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add metadata support erc1155 token instance #1420

Merged
merged 2 commits into from
May 5, 2023
Merged

fix: add metadata support erc1155 token instance #1420

merged 2 commits into from
May 5, 2023

Conversation

Naupio
Copy link
Contributor

@Naupio Naupio commented Apr 26, 2023 •
edited
Loading

What problem does this PR solve?

issue #1419
need process history data

Check List

Test

  • unit test

Task

  • none

@Naupio
Merge pull request Magickbase#1413 from Naupio/issue-1410
54d076b 
fix: add more async trigger point of account transaction count(issue 1410)
@Naupio
fix: add metadata support erc1155
66b631c
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 66b631c90ee75c13c7406d2463edf69b93ea1f4f-PR-1420

  • 0 of 69 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 55.282%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/godwoken_explorer/token/instance_metadata_retriever.ex 0 69 0.0%
Files with Coverage Reduction New Missed Lines %
lib/godwoken_explorer/graphql/types/custom/bigint.ex 1 0%
lib/godwoken_explorer/token/instance_metadata_retriever.ex 1 0%
lib/godwoken_explorer/graphql/types/custom/custom.ex 2 3.33%
Totals Coverage Status
Change from base Build e149c59629ac34a6e1ecdded455ba99b43041d85: -0.2%
Covered Lines: 3281
Relevant Lines: 5935
💛 - Coveralls

@Naupio Naupio merged commit 502e707 into Magickbase:godwoken-v1-testnet-prod May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmcNotafraid zmcNotafraid zmcNotafraid approved these changes

@FrederLu FrederLu Awaiting requested review from FrederLu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naupio @coveralls @zmcNotafraid