Postsrsd to avoid SPF rejects when Mailu used as MTA #1042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild failed |
kaiyou
requested changes
Jun 25, 2019
| @@ -112,4 +112,7 @@ milter_default_action = tempfail | |||
| ############### | |||
| # Extra Settings | |||
| ############### | |||
|
|
|||
| sender_canonical_maps = tcp:localhost:10001 | |||
There was a problem hiding this comment.
I would put these under a previous section specific to SRS instead of just extra settings.
| @@ -50,7 +51,9 @@ def start_podop(): | |||
|
|
|||
| convert("/conf/rsyslog.conf", "/etc/rsyslog.conf") | |||
|
|
|||
| # Run Podop and Postfix | |||
| # Generate SRS Secret file, start SRS, run Podop and Postfix | |||
There was a problem hiding this comment.
I feel bad about this. Maybe we could use native python (os.urandom and files)?
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #328
It implements Postsrsd with Mailu Postfix so that emails from alias are not rejected under SPF protocol.