Have computed var properties also use the queue to add invocations safely

[welshm]

I believe this fixes #333

[welshm]

@maxim-chipeev @AnthonyUccello-Faire

[welshm]

@navartis @spaluchiewicz looks like you're the most recent committers? Are you reviewing pull requests for this repo?

[maxim-chipeev]

Awesome, we need this for testing in an async environment

[welshm]

Anything I can do to help get this reviewed and merged?

[maxim-chipeev]

@g-amichnia Hi, I saw you were the second most recent reviewer…would you be so kind as to take a look?

[cassianomonteiro]

+1 on this.

[cassianomonteiro]

@spaluchiewicz Would you be able to take a look at this?

[roelspruit]

Hi. we ran into this issue in our project. Is somebody still going to review this MR? We'd love to have a fix for this issue in an official release.

[cassianomonteiro]

@spaluchiewicz Bumping this up, would you be able to take a look? This is becoming more critical as we adopt wider usages of async/await.

[Izepe]

@spaluchiewicz Can you guys take a look a this? We are having this same issue in our project

[etiennemartin-faire]

@welshm Nice to see you working on this! I noticed that this change also requires two more changes. Some of the templates are hardcoded in swift. You can see that we'll need a similar change here as well:

SwiftyMocky/Templates/VariableWrapper.swift

Line 22 in 3672eea

return "\n\t\tget {\t\(staticModifier)invocations.append(.\(propertyCaseGetName)); return \(staticModifier)\(privatePrototypeName) ?? \(returnValue) }"

SwiftyMocky/Templates/VariableWrapper.swift

Line 29 in 3672eea

return "\n\t\tset {\t\(staticModifier)invocations.append(.\(propertyCaseSetName)(.value(newValue))); \(variable.isStatic ? "\(scope)." : "")\(privatePrototypeName) = newValue }"

I was going to re-create this PR from a Fork I created. If you could add it let me know. Our of curiosity as well. Did you manage to get the tests running locally? The project file seems quite out of date.

[etiennemartin-faire]

Once we have both of these changes it would be great if we could cut a new release of this library. We've grown quite dependant of SwiftyMocky and would like to avoid having to fork the repo. @spaluchiewicz Do you have any guidance on how to get changes published in this repo? It seems like its not moving very much, and we haven't seen an official release in 2 years.

[welshm]

@welshm Nice to see you working on this! I noticed that this change also requires two more changes. Some of the templates are hardcoded in swift. You can see that we'll need a similar change here as well:

SwiftyMocky/Templates/VariableWrapper.swift

Line 22 in 3672eea

return "\n\t\tget {\t\(staticModifier)invocations.append(.\(propertyCaseGetName)); return \(staticModifier)\(privatePrototypeName) ?? \(returnValue) }"

SwiftyMocky/Templates/VariableWrapper.swift

Line 29 in 3672eea

return "\n\t\tset {\t\(staticModifier)invocations.append(.\(propertyCaseSetName)(.value(newValue))); \(variable.isStatic ? "\(scope)." : "")\(privatePrototypeName) = newValue }"

I was going to re-create this PR from a Fork I created. If you could add it let me know. Our of curiosity as well. Did you manage to get the tests running locally? The project file seems quite out of date.

I did have the tests passing when I originally made this PR - no idea if they run or pass at this point.

I can add these changes (likely tomorrow) and see if tests still run

[welshm]

@welshm Nice to see you working on this! I noticed that this change also requires two more changes. Some of the templates are hardcoded in swift. You can see that we'll need a similar change here as well:

SwiftyMocky/Templates/VariableWrapper.swift

Line 22 in 3672eea

return "\n\t\tget {\t\(staticModifier)invocations.append(.\(propertyCaseGetName)); return \(staticModifier)\(privatePrototypeName) ?? \(returnValue) }"

SwiftyMocky/Templates/VariableWrapper.swift

Line 29 in 3672eea

return "\n\t\tset {\t\(staticModifier)invocations.append(.\(propertyCaseSetName)(.value(newValue))); \(variable.isStatic ? "\(scope)." : "")\(privatePrototypeName) = newValue }"

I was going to re-create this PR from a Fork I created. If you could add it let me know. Our of curiosity as well. Did you manage to get the tests running locally? The project file seems quite out of date.

I did have the tests passing when I originally made this PR - no idea if they run or pass at this point.

I can add these changes (likely tomorrow) and see if tests still run

I made the changes but I haven't tested them (and likely - I won't). I've moved to using a different mocking framework because this one seems on life support at best 😢