Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richer responses & side effects (redirects, emails, >1 event, jobs, etc) #26

Open
chromy opened this issue Jun 21, 2024 · 1 comment
Open

Comments

@chromy
Copy link
Collaborator

chromy commented Jun 21, 2024

There are couple of features which we might want soon:

  • emailing user agreements (Let members sign an owners agreement before being made owners #25)
  • redirecting to custom pages from forms (e.g. POST /members/edit-name?id=1337 -> /member/1337)
  • redirecting from queries (e.g. /me -> /member/1234)
  • uploading images (problems, badges)
  • the ability to kick off background jobs/tasks (synching with reccurly / paxton etc)

and to be able to fit those features in it would be nice to expand the types that queries and commands can return (and maybe even partially unify them)

To start with my plan would be change queries from returning {body: string, title: string} to instead return Page | Redirect
where Page = {body: string, title: string} and Redirect = {url: string}.

chromy added a commit that referenced this issue Jun 21, 2024
@erkannt
Copy link
Collaborator

erkannt commented Jun 23, 2024

I like the idea of expanding the return type of queries to allow redirects. For success redirects after a command I'd suggest introducing a standard for an optional field that forms can submit as part of the request.

Lan2u pushed a commit that referenced this issue Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants