-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MakieLayout module #2008
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. using time
This PR does not change the using time. ttfp time
This PR does not change the ttfp time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you didn't check the docs for MakieLayout occurrences right? I know there's a couple mentions on the Axis page at least, so it would be good to also remove those
Pretty much the same as #2007 just for MakieLayout.
The extra module has just been leading to repeating code without real benefits, and we have been acting like Makie is the sole API exporter anyways.
This also removes the extra
__init__
and combines the precompiles and adds some new ones.Should also not be breaking due to
@deprecate_binding
, although the question remains when to remove the@deprecate_binding