Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boundingboxes #2184

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Fix boundingboxes #2184

merged 2 commits into from
Jul 27, 2022

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jul 26, 2022

Description

Fixes #2145 (boundingbox returning NaN)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added unit tests for new algorithms, conversion methods, etc.

Should this have a NEWS entry?

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 26, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 14.14s (14.09, 14.17) 0.03+- 19.80s (19.73, 19.88) 0.05+- 17.02s (16.99, 17.04) 0.02+- 14.67ms (14.62, 14.76) 0.05+- 73.54ms (72.99, 74.72) 0.58+-
master 14.07s (14.03, 14.12) 0.04+- 19.78s (19.71, 19.84) 0.05+- 17.01s (16.98, 17.04) 0.03+- 15.01ms (14.94, 15.09) 0.06+- 72.43ms (71.93, 73.07) 0.41+-
evaluation +0.46%, 0.07s slower X (1.93d, 0.00p, 0.03std) +0.10%, 0.02s invariant (0.38d, 0.49p, 0.05std) +0.04%, 0.01s invariant (0.26d, 0.64p, 0.02std) -2.33%, -0.34ms faster ✓ (-6.46d, 0.00p, 0.05std) +1.51%, 1.11ms slower X (2.21d, 0.00p, 0.49std)
CairoMakie 13.14s (12.91, 13.33) 0.16+- 20.51s (20.37, 20.65) 0.11+- 2.54s (2.51, 2.59) 0.03+- 20.32ms (19.36, 21.09) 0.64+- 24.72ms (24.45, 25.04) 0.19+-
master 12.88s (12.74, 13.02) 0.09+- 20.27s (20.06, 20.45) 0.13+- 2.54s (2.51, 2.57) 0.03+- 19.48ms (19.07, 20.05) 0.32+- 24.75ms (24.33, 25.10) 0.27+-
evaluation +1.95%, 0.26s slower X (1.96d, 0.00p, 0.13std) +1.16%, 0.24s slower X (1.95d, 0.00p, 0.12std) +0.22%, 0.01s invariant (0.20d, 0.72p, 0.03std) +4.16%, 0.85ms slower X (1.67d, 0.01p, 0.48std) -0.12%, -0.03ms invariant (-0.13d, 0.82p, 0.23std)
WGLMakie 17.19s (16.97, 17.35) 0.13+- 33.30s (33.07, 33.46) 0.14+- 46.05s (45.73, 47.39) 0.60+- 22.48ms (22.04, 22.97) 0.28+- 1.73s (1.71, 1.76) 0.02+-
master 17.11s (16.99, 17.23) 0.08+- 33.35s (33.09, 33.62) 0.17+- 45.63s (45.51, 45.76) 0.09+- 22.20ms (21.57, 22.97) 0.48+- 1.73s (1.71, 1.76) 0.02+-
evaluation +0.41%, 0.07s invariant (0.65d, 0.25p, 0.11std) -0.15%, -0.05s invariant (-0.32d, 0.57p, 0.15std) +0.90%, 0.41s invariant (0.96d, 0.12p, 0.35std) +1.27%, 0.29ms invariant (0.72d, 0.21p, 0.38std) +0.13%, 0.0s invariant (0.12d, 0.83p, 0.02std)

@ffreyer ffreyer merged commit dcb0fc2 into master Jul 27, 2022
@ffreyer ffreyer deleted the ff/boundingbox branch July 27, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boundingbox(plot) is broken
3 participants