-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix changing input types #2297
fix changing input types #2297
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
This looks like #2204, although is for WGLMakie, so it might be a completely different issue. Well, it was working with GLMakie, so indeed is a different thing. |
It's quite the different issue ;) |
* fix changing input types * add test
Incredibly enough, nobody seems to have run into this in a long time...
Seems like changing input types is pretty unpopular.
Changing types after
convert_arguments
isn't expected to work, since that usually changes plot type, but changing the input type toconvert_arguments
should have been working. Might have regressed in some of the observable refactors.