-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3D heatmaps in CairoMakie #2959
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
|
I think this is ready, no? :) |
It fixes the heatmap issue but the same issue still exists for image. I'm not sure what problems I ran into trying to fix it. I think I had issue getting the image to transform like the rect it's drawn on? |
I added the example from the issue as a refimg test. Maybe we should also add one for image and disable it in CairoMakie for now? |
Missing reference imagesFound 1 new images without existing references. |
Description
Fixes #2889, though the heatmap tiles aren't exactly aligned and image still doesn't work
Type of change
Checklist