Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define custom Linestyle type (fix #2851) #3135

Closed
wants to merge 1 commit into from

Conversation

Datseris
Copy link
Contributor

@Datseris Datseris commented Aug 8, 2023

This PR defines the new Linestyle type for handling custom linestyles. It also fixes #2851 already in its current state. What I don't know:

  • Where to put export Linestyle.
  • Where to put this Linestyle definition.
  • Where to put the deprecated convert method.
  • How to test this.

Any help is appreciated thank you all!

@ffreyer
Copy link
Collaborator

ffreyer commented Aug 10, 2023

  • Where to put export Linestyle.

Makie.jl

  • Where to put this Linestyle definition.

We usually have structs with their functions if we can, so conversions.jl is probably fine. Though maybe there is a point in putting it in Makiecore/types.jl, so it's available for packages that want to extend Makie without depending on Makie directly.

  • Where to put the deprecated convert method.

We haven't consistently put them in deprecated.jl but I think that would be best to keep track of deprecations.

  • How to test this.

As far as I can tell the convert_attribute pipeline is pretty short, starting from

Makie.convert_attribute(value, Makie.Key{:linestyle}(), Makie.Key{:lines}())

For testing I would call that with different values and check if they get converted correctly.

@SimonDanisch SimonDanisch mentioned this pull request Aug 30, 2023
@SimonDanisch
Copy link
Member

Continued in #3193

@Datseris
Copy link
Contributor Author

ops, i am sorry, i jave forgotten this one, thanks a lot for taking over@!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect linestyle representation in legend for custom linestyles
3 participants