Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Axis3 axis reversal attributes #3138

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

jkrumbiegel
Copy link
Member

@jkrumbiegel jkrumbiegel commented Aug 8, 2023

Description

Fixes #3137

Implementation could be cleaner I guess but I did the most straightforward thing I could think of and just flipped projection plus xor-ing everything in the decoration code. The Axis3 code is kind of annoying anyway because writing generic code for 3d cases is just confusing with the indexing etc, which is why I held off on doing this for so long in the first place.

Example:

test

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Aug 8, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 12.39s (12.32, 12.50) 0.07+- 1.07s (1.03, 1.09) 0.02+- 770.84ms (748.51, 812.86) 22.54+- 11.06ms (10.93, 11.14) 0.09+- 145.37ms (143.64, 146.88) 1.13+-
master 12.36s (12.18, 12.53) 0.11+- 1.14s (1.12, 1.16) 0.02+- 733.77ms (714.18, 759.76) 20.60+- 11.13ms (10.98, 11.22) 0.08+- 145.14ms (143.56, 147.36) 1.38+-
evaluation +0.22%, 0.03s invariant (0.29d, 0.60p, 0.09std) -6.16%, -0.07s faster✅ (-3.73d, 0.00p, 0.02std) +4.81%, 37.07ms slower X (1.72d, 0.01p, 21.57std) -0.60%, -0.07ms invariant (-0.77d, 0.18p, 0.09std) +0.16%, 0.23ms invariant (0.18d, 0.74p, 1.26std)
CairoMakie 11.15s (10.99, 11.51) 0.17+- 1.09s (1.07, 1.13) 0.02+- 224.71ms (220.14, 232.89) 4.54+- 11.08ms (10.86, 11.27) 0.13+- 6.62ms (6.47, 6.81) 0.12+-
master 11.08s (10.84, 11.35) 0.18+- 1.08s (1.06, 1.11) 0.02+- 233.99ms (228.42, 243.11) 5.03+- 11.18ms (10.99, 11.49) 0.18+- 6.71ms (6.58, 6.82) 0.10+-
evaluation +0.63%, 0.07s invariant (0.39d, 0.47p, 0.18std) +1.62%, 0.02s invariant (0.95d, 0.10p, 0.02std) -4.13%, -9.28ms faster ✓ (-1.94d, 0.00p, 4.78std) -0.89%, -0.1ms invariant (-0.63d, 0.26p, 0.15std) -1.30%, -0.09ms invariant (-0.80d, 0.16p, 0.11std)
WGLMakie 15.75s (15.48, 15.92) 0.15+- 1.45s (1.38, 1.50) 0.04+- 14.30s (14.06, 14.59) 0.19+- 17.34ms (16.18, 18.30) 0.82+- 1.43s (1.37, 1.48) 0.04+-
master 15.79s (15.59, 15.96) 0.11+- 1.45s (1.40, 1.50) 0.03+- 14.39s (14.13, 14.59) 0.15+- 17.46ms (16.52, 19.76) 1.09+- 1.42s (1.38, 1.49) 0.04+-
evaluation -0.24%, -0.04s invariant (-0.29d, 0.59p, 0.13std) -0.52%, -0.01s invariant (-0.20d, 0.71p, 0.04std) -0.63%, -0.09s invariant (-0.52d, 0.35p, 0.17std) -0.70%, -0.12ms invariant (-0.13d, 0.82p, 0.95std) +0.25%, 0.0s invariant (0.10d, 0.86p, 0.04std)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@Undermine28
Copy link

I compiled this commit locally and integrated it into my plotting. Features work as intended. Thanks a lot!

@jkrumbiegel jkrumbiegel merged commit cf62375 into master Aug 9, 2023
13 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/axis3-axis-reversals branch August 9, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zreversed feature in Axis3
3 participants