-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate plot attributes later, for axis specific plot attributes #3974
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
Would this mean that the attribute validation only works on top-level plots, and not subplots made in recipes? |
Thanks! Could we get a version out with this? I can do the changelog/bump PR when I get to my hotel but it would be great to release a GeoMakie that can be precompiled before JuliaCon :D |
Fix for MakieOrg/GeoMakie.jl#245
Exakt place of validation is up for discussion, but I think it shouldn't hurt to not validate in the constructor?
The problem is, that axis creation needs a finished plot object, but that means we can't create the axis and dispatch on it before handling axis specific attributes:
The source attribute is plot specific, and then creates a plot AND axis specific transform.
Open for discussion, but I'd not like to have this be something like
plot(...; (; user_attributes=(; source="...")))
, which is the only alternative I see right now.