Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate plot attributes later, for axis specific plot attributes #3974

Merged
merged 5 commits into from
Jul 7, 2024

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Jun 19, 2024

Fix for MakieOrg/GeoMakie.jl#245
Exakt place of validation is up for discussion, but I think it shouldn't hurt to not validate in the constructor?
The problem is, that axis creation needs a finished plot object, but that means we can't create the axis and dispatch on it before handling axis specific attributes:

using GeoMakie, GLMakie # you could use GLMakie too

lons = -180:180
lats = -90:90
field = [exp(cosd(l)) + 3(y / 90) for l in lons, y in lats]
sp = surface(lons, lats, field; axis=(; type=GeoAxis), source="+proj=longlat +datum=WGS84")

The source attribute is plot specific, and then creates a plot AND axis specific transform.
Open for discussion, but I'd not like to have this be something like plot(...; (; user_attributes=(; source="..."))), which is the only alternative I see right now.

@MakieBot
Copy link
Collaborator

MakieBot commented Jun 19, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.26s (4.21, 4.34) 0.05+- 104.83ms (102.17, 107.96) 2.27+- 484.79ms (471.33, 493.11) 8.71+- 8.60ms (8.21, 8.99) 0.26+- 25.72ms (25.41, 26.37) 0.36+-
master 4.25s (4.16, 4.37) 0.07+- 104.74ms (102.12, 109.75) 2.96+- 478.79ms (472.14, 496.26) 8.09+- 8.47ms (8.37, 8.55) 0.08+- 25.57ms (25.38, 25.82) 0.17+-
evaluation 1.00x invariant, 0.01s (0.21d, 0.70p, 0.06std) 1.00x invariant, 0.09ms (0.03d, 0.95p, 2.61std) 0.99x invariant, 6.0ms (0.71d, 0.21p, 8.40std) 0.99x invariant, 0.13ms (0.65d, 0.26p, 0.17std) 0.99x invariant, 0.15ms (0.55d, 0.33p, 0.26std)
CairoMakie 3.85s (3.82, 3.88) 0.02+- 105.92ms (103.50, 110.47) 2.53+- 129.88ms (126.51, 140.06) 4.83+- 8.49ms (8.36, 8.59) 0.09+- 988.54μs (976.44, 1002.74) 8.03+-
master 3.59s (3.55, 3.62) 0.03+- 105.01ms (103.49, 109.56) 2.12+- 128.85ms (127.87, 131.48) 1.31+- 8.24ms (8.10, 8.39) 0.10+- 991.01μs (983.91, 1001.30) 6.24+-
evaluation 0.93x slower❌, 0.25s (10.69d, 0.00p, 0.02std) 0.99x invariant, 0.9ms (0.39d, 0.48p, 2.32std) 0.99x invariant, 1.03ms (0.29d, 0.60p, 3.07std) 0.97x slower X, 0.25ms (2.68d, 0.00p, 0.09std) 1.00x invariant, -2.46μs (-0.34d, 0.53p, 7.14std)
WGLMakie 4.55s (4.48, 4.64) 0.06+- 108.33ms (105.01, 113.81) 2.88+- 9.14s (8.92, 9.38) 0.19+- 9.60ms (9.35, 9.82) 0.19+- 70.62ms (69.76, 72.26) 0.89+-
master 4.56s (4.49, 4.62) 0.05+- 111.55ms (106.96, 125.59) 6.47+- 9.33s (9.10, 9.49) 0.15+- 9.61ms (9.33, 10.60) 0.44+- 70.64ms (69.82, 71.61) 0.64+-
evaluation 1.00x invariant, -0.01s (-0.14d, 0.79p, 0.06std) 1.03x invariant, -3.21ms (-0.64d, 0.26p, 4.67std) 1.02x invariant, -0.18s (-1.09d, 0.07p, 0.17std) 1.00x invariant, -0.01ms (-0.03d, 0.96p, 0.32std) 1.00x invariant, -0.02ms (-0.03d, 0.96p, 0.77std)

@asinghvi17
Copy link
Member

Would this mean that the attribute validation only works on top-level plots, and not subplots made in recipes?

@SimonDanisch SimonDanisch merged commit de1dfc3 into master Jul 7, 2024
18 checks passed
@SimonDanisch SimonDanisch deleted the sd/later-validation branch July 7, 2024 14:13
@asinghvi17
Copy link
Member

Thanks! Could we get a version out with this? I can do the changelog/bump PR when I get to my hotel but it would be great to release a GeoMakie that can be precompiled before JuliaCon :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants