Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we wait for the screen session #4316

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Sep 4, 2024

This should close #3921

@SimonDanisch SimonDanisch marked this pull request as ready for review September 4, 2024 09:32
@MakieBot
Copy link
Collaborator

MakieBot commented Sep 4, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.54s (4.48, 4.61) 0.05+- 113.80ms (108.68, 123.78) 5.13+- 573.83ms (555.89, 591.13) 12.24+- 9.39ms (9.09, 9.66) 0.20+- 26.67ms (26.40, 26.87) 0.19+-
master 4.48s (4.39, 4.58) 0.06+- 113.29ms (108.24, 120.18) 3.94+- 566.53ms (552.75, 589.84) 11.86+- 9.16ms (8.98, 9.55) 0.20+- 26.58ms (26.37, 26.87) 0.19+-
evaluation 0.99x invariant, 0.06s (1.10d, 0.06p, 0.05std) 1.00x invariant, 0.52ms (0.11d, 0.84p, 4.54std) 0.99x invariant, 7.3ms (0.61d, 0.28p, 12.05std) 0.98x invariant, 0.22ms (1.12d, 0.06p, 0.20std) 1.00x invariant, 0.09ms (0.48d, 0.38p, 0.19std)
CairoMakie 4.03s (3.95, 4.08) 0.04+- 109.87ms (103.79, 117.36) 4.47+- 174.41ms (163.47, 191.55) 9.95+- 9.73ms (9.55, 10.07) 0.18+- 1.22ms (1.20, 1.25) 0.02+-
master 3.99s (3.89, 4.11) 0.09+- 108.72ms (105.61, 115.07) 3.78+- 170.27ms (166.34, 178.76) 4.54+- 9.54ms (9.42, 9.71) 0.10+- 1.19ms (1.14, 1.23) 0.03+-
evaluation 0.99x invariant, 0.04s (0.54d, 0.34p, 0.06std) 0.99x invariant, 1.15ms (0.28d, 0.61p, 4.12std) 0.98x invariant, 4.14ms (0.54d, 0.34p, 7.25std) 0.98x slower X, 0.2ms (1.34d, 0.03p, 0.14std) 0.97x slower X, 0.03ms (1.25d, 0.04p, 0.03std)
WGLMakie 4.57s (4.51, 4.66) 0.05+- 107.24ms (105.02, 113.86) 3.06+- 9.22s (9.20, 9.24) 0.01+- 11.08ms (10.98, 11.17) 0.07+- 117.30ms (113.71, 120.30) 2.69+-
master 4.56s (4.52, 4.63) 0.04+- 105.51ms (103.88, 107.83) 1.32+- 9.27s (9.10, 9.53) 0.14+- 11.32ms (11.07, 11.97) 0.30+- 125.62ms (116.51, 159.90) 15.35+-
evaluation 1.00x invariant, 0.01s (0.12d, 0.83p, 0.04std) 0.98x invariant, 1.73ms (0.73d, 0.21p, 2.19std) 1.01x invariant, -0.05s (-0.53d, 0.36p, 0.07std) 1.02x invariant, -0.24ms (-1.12d, 0.08p, 0.19std) 1.07x noisy🤷‍♀️, -8.32ms (-0.76d, 0.20p, 9.02std)

@SimonDanisch SimonDanisch merged commit 8617742 into master Sep 4, 2024
18 checks passed
@SimonDanisch SimonDanisch deleted the sd/fix-wgl-init branch September 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

WGLMakie+Pluto record/animation results in MethodError: no method matching wait_for_ready(::Nothing)
2 participants