Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lift! and finalize #4304 #4352

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

EdsterG
Copy link
Contributor

@EdsterG EdsterG commented Sep 12, 2024

Description

Fixes #4304
Followup to #4337

This PR also adds a lift! definition.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@SimonDanisch SimonDanisch merged commit a98f560 into MakieOrg:master Sep 13, 2024
17 of 18 checks passed
@SimonDanisch
Copy link
Member

Thank you! :)

@asinghvi17
Copy link
Member

Thanks!!

@EdsterG EdsterG deleted the eddie/jl_lift_cleanup branch September 13, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Tracking plot types that don't yet have all lifts linked to the plot object
3 participants