Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change automatic color generation for Voronoiplot #4357

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

DanielVandH
Copy link
Contributor

@DanielVandH DanielVandH commented Sep 13, 2024

Description

Fixes #4344 by using a consistent method for generating colors. Using this approach the colors will be consistent between plots even if generators were removed or added. The old approach wasn't optimal since the Set defining each_generator(vorn) isn't ordered consistently across tessellations if the generator set changed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@DanielVandH
Copy link
Contributor Author

This PR breaks

Voronoiplot for a centroidal tessellation with an automatic colormap.png
Voronoiplot after adding points.png
Voronoiplot for a tessellation with a custom bounding box.png

because of the new color generation method. I've checked them myself and nothing else is broken, it's just the colors. I don't see a consistent way to define the colors that is consistent with the colors generated by the previous method, so is just regenerating the images sufficient?

@ffreyer
Copy link
Collaborator

ffreyer commented Sep 18, 2024

I think it's fine that the automatically chosen colors change, but it would mean that we consider this breaking and delay it until the next breaking release.

@ffreyer ffreyer added the breaking a PR with breaking changes label Sep 18, 2024
@SimonDanisch
Copy link
Member

I'm wondering if we can tag this as a patch version, considering that it's not that close to core Makie and the colors are somewhat arbitrary.
I guess I'd let @DanielVandH decide this.

@DanielVandH
Copy link
Contributor Author

It would be nice to get it in earlier, but I don't mind waiting for another breaking release if you prefer . I would agree with you though that I don't think it's so breaking.

@ffreyer ffreyer mentioned this pull request Oct 14, 2024
5 tasks
@ffreyer ffreyer changed the base branch from master to breaking-0.22 November 14, 2024 15:13
@ffreyer ffreyer closed this Nov 14, 2024
@ffreyer ffreyer reopened this Nov 14, 2024
@ffreyer ffreyer closed this Nov 14, 2024
@ffreyer ffreyer reopened this Nov 14, 2024
@ffreyer ffreyer merged commit 89a1d50 into MakieOrg:breaking-0.22 Nov 14, 2024
44 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking a PR with breaking changes
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

voronoiplot default colours depend too much on the generator order
4 participants