-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change automatic color generation for Voronoiplot #4357
Conversation
This PR breaks Voronoiplot for a centroidal tessellation with an automatic colormap.png because of the new color generation method. I've checked them myself and nothing else is broken, it's just the colors. I don't see a consistent way to define the colors that is consistent with the colors generated by the previous method, so is just regenerating the images sufficient? |
I think it's fine that the automatically chosen colors change, but it would mean that we consider this breaking and delay it until the next breaking release. |
I'm wondering if we can tag this as a patch version, considering that it's not that close to core Makie and the colors are somewhat arbitrary. |
It would be nice to get it in earlier, but I don't mind waiting for another breaking release if you prefer . I would agree with you though that I don't think it's so breaking. |
Description
Fixes #4344 by using a consistent method for generating colors. Using this approach the colors will be consistent between plots even if generators were removed or added. The old approach wasn't optimal since the
Set
definingeach_generator(vorn)
isn't ordered consistently across tessellations if the generator set changed.Type of change
Checklist