Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix heatmapshader for ranges #4434

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix heatmapshader for ranges #4434

merged 3 commits into from
Oct 2, 2024

Conversation

SimonDanisch
Copy link
Member

No description provided.

@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label Oct 1, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 1, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.61s (4.57, 4.64) 0.03+- 108.26ms (106.93, 108.91) 0.83+- 410.96ms (407.00, 413.87) 2.48+- 9.05ms (8.85, 9.30) 0.19+- 25.87ms (25.62, 26.95) 0.48+-
master 4.64s (4.62, 4.67) 0.02+- 108.84ms (108.04, 109.87) 0.61+- 414.48ms (410.91, 417.08) 2.08+- 9.38ms (9.27, 9.48) 0.07+- 25.68ms (25.65, 25.75) 0.03+-
evaluation 1.01x faster ✓, -0.03s (-1.48d, 0.02p, 0.02std) 1.01x invariant, -0.59ms (-0.81d, 0.16p, 0.72std) 1.01x faster ✓, -3.52ms (-1.54d, 0.01p, 2.28std) 1.04x faster ✓, -0.34ms (-2.38d, 0.00p, 0.13std) 0.99x invariant, 0.18ms (0.54d, 0.35p, 0.26std)
CairoMakie 4.41s (4.38, 4.45) 0.02+- 110.05ms (108.11, 114.19) 2.34+- 164.93ms (163.24, 166.19) 1.10+- 8.92ms (8.89, 8.95) 0.02+- 1.12ms (1.12, 1.13) 0.01+-
master 4.40s (4.37, 4.43) 0.02+- 110.13ms (108.46, 112.97) 1.69+- 170.17ms (163.12, 197.05) 12.01+- 8.85ms (8.78, 8.92) 0.06+- 1.12ms (1.12, 1.14) 0.01+-
evaluation 1.00x invariant, 0.02s (0.76d, 0.18p, 0.02std) 1.00x invariant, -0.09ms (-0.04d, 0.94p, 2.02std) 1.03x invariant, -5.24ms (-0.61d, 0.29p, 6.56std) 0.99x slower X, 0.07ms (1.56d, 0.02p, 0.04std) 1.00x invariant, -0.0ms (-0.02d, 0.97p, 0.01std)
WGLMakie 5.24s (5.14, 5.33) 0.08+- 112.03ms (109.84, 116.81) 2.33+- 9.16s (9.06, 9.23) 0.07+- 11.74ms (11.42, 12.04) 0.25+- 119.51ms (115.91, 124.65) 3.00+-
master 5.22s (5.15, 5.26) 0.04+- 111.85ms (110.43, 114.09) 1.40+- 9.26s (9.04, 9.41) 0.11+- 11.99ms (11.36, 14.05) 0.92+- 118.28ms (113.80, 122.91) 3.43+-
evaluation 1.00x invariant, 0.02s (0.41d, 0.46p, 0.06std) 1.00x invariant, 0.18ms (0.09d, 0.87p, 1.86std) 1.01x invariant, -0.1s (-1.05d, 0.08p, 0.09std) 1.02x invariant, -0.25ms (-0.38d, 0.51p, 0.59std) 0.99x invariant, 1.23ms (0.38d, 0.49p, 3.21std)

@SimonDanisch SimonDanisch reopened this Oct 2, 2024
@SimonDanisch SimonDanisch merged commit 59456d3 into master Oct 2, 2024
28 of 34 checks passed
@SimonDanisch SimonDanisch deleted the sd/fix-heatmap-resampler branch October 2, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants