bump more core extensions #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Jul 14, 2020
inventory_refresh.gemspec
Outdated
| @@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_dependency "activerecord", "~> 5.0" | |||
| spec.add_dependency "more_core_extensions", "~> 3.5" | |||
| spec.add_dependency "more_core_extensions", "~> 4.0" | |||
There was a problem hiding this comment.
It looks like ">=3.5", "< 5" is safe here.
more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221
|
Checked commit d-m-u@3669060 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
Yes, MIQ uses an older version (v0.2) so we'll need to cherry-pick this back to that branch as well |
agrare
approved these changes
Jul 14, 2020
agrare
added a commit
that referenced
this pull request
Jul 14, 2020
bump more core extensions (cherry picked from commit 1caa980)
agrare
added a commit
that referenced
this pull request
Jul 14, 2020
Changes: * Bump more core extensions (#93)
|
Release v0.3.6 and v0.2.2 with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more core ext's on 4.1.0
update for update sake
https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
array added *
#compact_map- Collect non-nil results from the blockarray added
#tabular_sort- Sorts an Array of Hashes by specific columnshierarchy added
#descendant_get- Returns the descendant with a given namethe two breaking changes:
a minor header output change was made that hasn't been released yet to make tableize more markdown compliant
see ManageIQ/linux_admin#221