Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config ignores insecure-skip-tls-verify field #555

Closed
cben opened this issue Mar 23, 2022 · 1 comment
Closed

Config ignores insecure-skip-tls-verify field #555

cben opened this issue Mar 23, 2022 · 1 comment
Labels
bug

Comments

@cben
Copy link
Collaborator

cben commented Mar 23, 2022

Tightly related to #554, also broken ever since Kubeclient::Config was added (I'm fixing them together): insecure-skip-tls-verify field in kubeconfig was never honored.

The distinction is that #554 is about the default being dangerous, and this ticket is about inability to override the default (either way) by insecure-skip-tls-verify.
@cben cben added the bug label Mar 23, 2022
This was referenced Mar 23, 2022
Closed
Merged
Merged
Merged
Open
cben added a commit to cben/kubeclient that referenced this issue Mar 23, 2022
@cben
CHANGELOG and README fixups about ManageIQ#554, ManageIQ#555
6670fab 
Tiny followup to ManageIQ#556.
Sorry for noise, had these locally but forgot to push before merging.
If I start backporting, CHANGELOG.md on master branch might not always be updated
with all backports (it SHOULD, but it will require separate merges to master).
So I prefer pointing to the vulnerability issue as the "source of truth".
Also, security impact will be better discussed on the issue.
cben added a commit that referenced this issue Mar 23, 2022
@cben
Merge pull request #559 from cben/v4.y-security-config-ssl_verify-cha…
2d241e3 
…ngelog

fixup CHANGELOG and README about #554, #555
@cben cben mentioned this issue Mar 23, 2022
Closed
@cben
Copy link
Collaborator Author

cben commented Jul 24, 2022

Closing, this has been fixed both in 4.9.3 and on master branch.

@cben cben closed this as completed Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cben