Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes to the AWS EKS Credentials into the v4.y branch for release #634

Conversation

snorlaX-sleeps
Copy link
Contributor

@snorlaX-sleeps snorlaX-sleeps commented Jun 18, 2024

This PR adds regional support to the method, as well as allowing the kuebclient gem to be used in govcloud
All of this code is available from the main branch and was added in the following PRs:

Without these (old) changes, the currently released gem is unusable.
Some of these changes were added before the v5 cutoff started, but never got released

Fixes: #527

Changes tested in our account - currently patching a copy of this file into our Docker build, overwriting the latest release

…e - adds regional support to the method, as well as allowing the kuebclient gem to be used in govcloud

Signed-off-by: snorlaX-sleeps <[email protected]>
@snorlaX-sleeps
Copy link
Contributor Author

@miq-bot add-label enhancement
@miq-bot add-label aws
@miq-bot add-label eks
@miq-bot add-label aws_eks

@agrare
Copy link
Member

agrare commented Jun 18, 2024

Thanks for the nudge @snorlaX-sleeps, I'll backport these commits and get the v4.y branch green on CI and release a v4.12.0 shortly

@snorlaX-sleeps
Copy link
Contributor Author

Thanks @agrare - I was unsure of the process around backporting, but this was a blocker for the last week or two and it's only when I really went digging that I remembered this was a thing a few years back 🙂

@agrare
Copy link
Member

agrare commented Jun 18, 2024

@snorlaX-sleeps I've released v4.12.0 including the three PRs that you linked here
https://github.com/ManageIQ/kubeclient/releases/tag/v4.12.0
https://rubygems.org/gems/kubeclient/versions/4.12.0

Let me know if that works for you, thanks!

@agrare
Copy link
Member

agrare commented Jun 18, 2024

I was unsure of the process around backporting

Yeah I like to cherry-pick individual merge commits to maintain the commit history and include a changelog and summary in gpg-signed commit and tag.

@agrare
Copy link
Member

agrare commented Jun 18, 2024

There is a failure on windows x truffleruby-head and that test doesn't exist on master which is interesting it went straight to v4.y but it is a setup failure not a code failure, might revert that PR that added the test only to v4.y and backport it properly once the master PR is merged.

@snorlaX-sleeps
Copy link
Contributor Author

thanks @agrare - I've done a local test with the new gem, with the expected result, will attempt a full build and test tomorrow!

@snorlaX-sleeps
Copy link
Contributor Author

@agrare - can confirm this is now working for us in both commercial and govcloud AWS accounts.
Going to close this since you've already backported the change 🙂
Thanks for jumping on this so quickly

@snorlaX-sleeps snorlaX-sleeps deleted the release_aws_eks_fixes_for_v4.y branch June 19, 2024 17:59
@agrare
Copy link
Member

agrare commented Jun 19, 2024

Awesome glad to hear it @snorlaX-sleeps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants