Add plugin display name #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Aug 28, 2018
lib/manageiq/api/engine.rb
Outdated
| @@ -34,6 +34,10 @@ def self.log_kv(key, val) | |||
| def vmdb_plugin? | |||
| true | |||
| end | |||
|
|
|||
| def self.plugin_name | |||
| _('API') | |||
There was a problem hiding this comment.
Should this be more specific like REST API?
There was a problem hiding this comment.
Sure, why not. Fixed.
mzazrivec
force-pushed
the
add_plugin_name
branch
from
a018729
to
95f05f5
Compare
|
Checked commit mzazrivec@95f05f5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@abellotti or @gtanzillo Can you merge? |
abellotti
approved these changes
Aug 29, 2018
|
Thanks @mzazrivec for enhancing this. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ManageIQ/manageiq-ui-classic#4496 for primary motivation.