Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'dump_root' logic into common method location and include as embedded method #350

Closed
gmcculloug opened this issue Jul 4, 2018 · 1 comment
Closed

Move 'dump_root' logic into common method location and include as embedded method #350

gmcculloug opened this issue Jul 4, 2018 · 1 comment
Assignees
@billfitzgerald0120
Labels
refactoring

Comments

@gmcculloug
Copy link
Member

The basic "dump_root" logic from the InspectMe method is used in several methods:

ManageIQ/Cloud/Orchestration/Retirement/StateMachines/Methods.class/__methods__/start_retirement.rb
ManageIQ/Control/Email.class/__methods__/parse_alerts.rb
ManageIQ/Infrastructure/VM/Retirement/StateMachines/Methods.class/__methods__/start_retirement.rb
ManageIQ/Service/Provisioning/StateMachines/Methods.class/__methods__/check_provisioned.rb
ManageIQ/Service/Provisioning/StateMachines/Methods.class/__methods__/groupsequencecheck.rb
ManageIQ/Service/Provisioning/StateMachines/Methods.class/__methods__/provision.rb

The logic should be moved into a new method which can then be included into the other methods using the Embedded method feature. The InspectMe method should also include this logic through the embedded method as well.

Potentially all the methods in InspectMe could be exposed in a utility class for reuse and the InspectMe method today would just become simple calls to those embedded methods.

cc @tinaafitz @mkanoor
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jul 16, 2018
@billfitzgerald0120
Created DumpRoot instance and method in System/Request class.
05e9751 
This is a new method which can then be included into the other methods using the Embedded method feature.

ManageIQ#350
@billfitzgerald0120 billfitzgerald0120 mentioned this issue Jul 16, 2018
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jul 17, 2018
@billfitzgerald0120
Created DumpRoot method in System/CommonMethods/Utils class.
6b003e4 
This is a new method which can then be included into the other methods using the Embedded method feature.
Created System/CommonMethods/Utils class.

ManageIQ#350
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jul 27, 2018
@billfitzgerald0120
Created DumpRoot method in System/CommonMethods/Utils class.
cf3591e 
This is a new method which can then be included into the other methods using the Embedded method feature.
Created System/CommonMethods/Utils class.

ManageIQ#350

Changed name to LogObject and many other changes .....
Added documentation in the method
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jul 28, 2018
@billfitzgerald0120
Created DumpRoot method in System/CommonMethods/Utils class.
d04360a 
This is a new method which can then be included into the other methods using the Embedded method feature.
Created System/CommonMethods/Utils class.

ManageIQ#350

Changed name to LogObject and many other changes .....
Added documentation in the method
Fixed extra line
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jul 31, 2018
@billfitzgerald0120
Created DumpRoot method in System/CommonMethods/Utils class.
10f0ca6 
This is a new method which can then be included into the other methods using the Embedded method feature.
Created System/CommonMethods/Utils class.

ManageIQ#350

Changed name to LogObject and many other changes .....
Added documentation in the method
Fixed extra line
Fixed rubocop errors in spec
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Aug 2, 2018
@billfitzgerald0120
Adding Inspectme functionality into log_object embedded method.
7b98161 
Added the ability to log all attributes, associations, and tags.
Inspectme is a great tool for debugging and now will be available from an embedded method.

ManageIQ#350
@billfitzgerald0120 billfitzgerald0120 mentioned this issue Aug 2, 2018
Merged
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Aug 3, 2018
@billfitzgerald0120
Adding Inspectme functionality into log_object embedded method.
469bde6 
Added the ability to log all attributes, associations, and tags.
Inspectme is a great tool for debugging and now will be available from an embedded method.

ManageIQ#350

Added tests
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Aug 13, 2018
@billfitzgerald0120
Adding Inspectme functionality into log_object embedded method.
be9fe61 
Added the ability to log all attributes, associations, and tags.
Inspectme is a great tool for debugging and now will be available from an embedded method.

ManageIQ#350

Added tests
Changed object_prefix to log_prefix as requested.
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Aug 13, 2018
@billfitzgerald0120
Adding Inspectme functionality into log_object embedded method.
3295adc 
Added the ability to log all attributes, associations, and tags.
Inspectme is a great tool for debugging and now will be available from an embedded method.

ManageIQ#350

Added tests
Changed object_prefix to log_prefix as requested.

Changed method to obj.respond_to?(:object_class) as requested.
@gmcculloug
Copy link
Member Author

Issue resolved with #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billfitzgerald0120 billfitzgerald0120

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmcculloug @billfitzgerald0120