Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notifications for finish_retirement. #106

Merged
merged 1 commit into from
May 2, 2017
Merged

Add notifications for finish_retirement. #106

merged 1 commit into from
May 2, 2017

Conversation

tinaafitz
Copy link
Member

@miq-bot miq-bot added the wip label May 1, 2017
@tinaafitz
Copy link
Member Author

@miq-bot add-label blocker, bug, services, fine/yes

@tinaafitz tinaafitz mentioned this pull request May 1, 2017
Merged
@tinaafitz
Copy link
Member Author

Related PR:
ManageIQ/manageiq#14955

@tinaafitz tinaafitz force-pushed the add_notification_to_finish_retirement branch from 07f05dd to b363ff0 Compare May 1, 2017 22:19
@tinaafitz tinaafitz changed the title [WIP] Add notifications for finish_retirement. Add notifications for finish_retirement. May 2, 2017
@miq-bot miq-bot removed the wip label May 2, 2017
@gmcculloug
Copy link
Member

@tinaafitz Please review test failures.

@tinaafitz tinaafitz force-pushed the add_notification_to_finish_retirement branch from b363ff0 to de8a759 Compare May 2, 2017 17:38
@miq-bot
Copy link
Member

miq-bot commented May 2, 2017

Checked commit tinaafitz@de8a759 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks fine. 🏆

@tinaafitz
Copy link
Member Author

@gmcculloug Fixed test failures.

@gmcculloug gmcculloug merged commit 4b97013 into ManageIQ:master May 2, 2017
@gmcculloug gmcculloug added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
@gmcculloug gmcculloug self-assigned this May 2, 2017
simaishi pushed a commit that referenced this pull request May 2, 2017
@gmcculloug @simaishi
Merge pull request #106 from tinaafitz/add_notification_to_finish_ret…
5411101 
…irement

Add notifications for finish_retirement.
(cherry picked from commit 4b97013)

https://bugzilla.redhat.com/show_bug.cgi?id=1447367
@simaishi
Copy link
Contributor

simaishi commented May 2, 2017

Fine backport details:

$ git log -1
commit 54111016d389c8a3b0c98d256617c2c699615438
Author: Greg McCullough <[email protected]>
Date:   Tue May 2 13:54:15 2017 -0400

    Merge pull request #106 from tinaafitz/add_notification_to_finish_retirement
    
    Add notifications for finish_retirement.
    (cherry picked from commit 4b97013913f288f3a99b1133005ecbc70a4f76cb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
blocker bug fine/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinaafitz @gmcculloug @miq-bot @simaishi