Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VM reconfiguration email. #116

Merged
merged 1 commit into from
May 17, 2017

Conversation

billfitzgerald0120
Copy link
Contributor

@billfitzgerald0120 billfitzgerald0120 commented May 17, 2017

Removed vm_reconfigure email from System/Event/MiqEvent/Policy instance.
This event is being called sometimes when provisioning.

https://bugzilla.redhat.com/show_bug.cgi?id=1422208

@miq-bot add_label bug, fine/yes

Reverts one of the changes make in PR ManageIQ/manageiq#7399

Removed vm_reconfigure email from System/Event/MiqEvent/Policy instance.
This event is being called sometimes when provisioning.

https://bugzilla.redhat.com/show_bug.cgi?id=1422208

@miq-bot add_label bug, fine/yes
@miq-bot
Copy link
Member

miq-bot commented May 17, 2017

Checked commit billfitzgerald0120@ef811fc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug gmcculloug self-assigned this May 17, 2017
@gmcculloug gmcculloug requested a review from tinaafitz May 17, 2017 16:44
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billfitzgerald0120 Looks good.

@gmcculloug gmcculloug merged commit a007a3f into ManageIQ:master May 17, 2017
simaishi pushed a commit that referenced this pull request Jun 8, 2017
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit c8f7604c3bff0f252a0a5ed4d4545054075c3ff2
Author: Greg McCullough <[email protected]>
Date:   Wed May 17 13:45:47 2017 -0400

    Merge pull request #116 from billfitzgerald0120/vmreconfig_no_email
    
    Remove VM reconfiguration email.
    (cherry picked from commit a007a3f9828314e4ea36045f5ddb3c4a3ec39e9e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460031

lfu added a commit to lfu/manageiq that referenced this pull request Aug 23, 2017
…tion.

VmReconfigureTaskComplete email notification in automate has been removed by ManageIQ/manageiq-content#116.
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this pull request Feb 6, 2018
This was done previously because this event is sometimes called during provisioning.

See PR: ManageIQ#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants