-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove VM reconfiguration email. #116
Merged
gmcculloug
merged 1 commit into
ManageIQ:master
from
billfitzgerald0120:vmreconfig_no_email
May 17, 2017
Merged
Remove VM reconfiguration email. #116
gmcculloug
merged 1 commit into
ManageIQ:master
from
billfitzgerald0120:vmreconfig_no_email
May 17, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed vm_reconfigure email from System/Event/MiqEvent/Policy instance. This event is being called sometimes when provisioning. https://bugzilla.redhat.com/show_bug.cgi?id=1422208 @miq-bot add_label bug, fine/yes
Checked commit billfitzgerald0120@ef811fc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
tinaafitz
approved these changes
May 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billfitzgerald0120 Looks good.
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
Remove VM reconfiguration email. (cherry picked from commit a007a3f) https://bugzilla.redhat.com/show_bug.cgi?id=1460031
Fine backport details:
|
lfu
added a commit
to lfu/manageiq
that referenced
this pull request
Aug 23, 2017
…tion. VmReconfigureTaskComplete email notification in automate has been removed by ManageIQ/manageiq-content#116.
billfitzgerald0120
added a commit
to billfitzgerald0120/manageiq-content
that referenced
this pull request
Feb 6, 2018
This was done previously because this event is sometimes called during provisioning. See PR: ManageIQ#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed vm_reconfigure email from System/Event/MiqEvent/Policy instance.
This event is being called sometimes when provisioning.
https://bugzilla.redhat.com/show_bug.cgi?id=1422208
@miq-bot add_label bug, fine/yes
Reverts one of the changes make in PR ManageIQ/manageiq#7399