v2v: Fix filtering of drivers ISO to display #143
Conversation
Formerly the list_dirver_isos method only took under account ISOs with names of the form of 'RHEV-toolsSetup_3.5_15.iso' or 'oVirt-toolsSetup-4.1-3.fc24.iso' and ISOs with names like 'rhev-tools-setup.iso' were ignored. Fixed the filtering regex to cover both cases. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1471823
|
@miq-bot assign @gmcculloug |
|
@miq-bot add_label fine/yes |
|
Checked commit matobet@9d77fab with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| @@ -21,7 +21,7 @@ def main | |||
| values_hash[nil] = '-- no ISO datastore for provider --' | |||
| else | |||
| values_hash[nil] = '-- select drivers ISO from list --' | |||
| provider.iso_datastore.iso_images.pluck(:name).grep(/toolsSetup/).each do |iso| | |||
| provider.iso_datastore.iso_images.pluck(:name).grep(/tools.*setup/i).each do |iso| | |||
There was a problem hiding this comment.
@matobet Is this condition too loose for the lookup? Where do the iso_image names come from, does we have control over them?
There was a problem hiding this comment.
@gmcculloug The iso images come from the RHV iso domain (only RHV providers may be selected in the target infra provider dropdown) and it contains ISOs of given naming convention (among other random ISOs which we don't want to list for this purpose). This convention alas has changed between 3.6 ({RHEV,oVirt}-toolsSetup) and 4.0 (rhev-tools-setup).
We believe that this regex is the right balance between strictness and generality.
v2v: Fix filtering of drivers ISO to display (cherry picked from commit 11d379e) https://bugzilla.redhat.com/show_bug.cgi?id=1479405
|
Fine backport details: |
Formerly the list_dirver_isos method only took under account ISOs with names of
the form of 'RHEV-toolsSetup_3.5_15.iso' or 'oVirt-toolsSetup-4.1-3.fc24.iso'
and ISOs with names like 'rhev-tools-setup.iso' were ignored.
Fixed the filtering regex to cover both cases.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1471823