Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New refresh method callable from the automate #159

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Aug 2, 2017

New refresh method callable from the automate, it tries
to call targeted manager refresh if defined, otherwise fallback to
full refresh.

This is needed for invoking https://github.com/ManageIQ/manageiq-automation_engine/blob/master/lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_builtin_method.rb#L101

New refresh method callable from the automate, it tries
to call targeted manager refresh if defined, otherwise fallback to
full refresh.
@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2017

Checked commit Ladas@f483bb5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@Ladas
Copy link
Contributor Author

Ladas commented Aug 2, 2017

@cc @gmcculloug @blomquisg we need this so we can invoke the new targeted refresh from the automate

the usage is just "/System/event_handlers/refresh" and the targets are scanned inside, or the result can be full refresh, if we disable the targeted refresh via settings.


@gmcculloug not related CI error it seems?

@gmcculloug gmcculloug self-assigned this Aug 2, 2017
@gmcculloug
Copy link
Member

@lfu Please review

@lfu
Copy link
Member

lfu commented Aug 3, 2017

@Ladas Does this refresh method work only for Amazon? Or eventually it will work for all providers?
Would like to know if this is a replacement for event_action_refresh and event_action_refresh_sync.

@Ladas
Copy link
Contributor Author

Ladas commented Aug 4, 2017

@lfu we will use it for targeted refresh of AWS and OpenStack, for 4.6. In other providers, it would just invoke full refresh, because of a missing Settings value.

At some point, it will replace event_action_refresh, but that will take some time. (we will need targeted graph refresh in all providers)

@lfu
Copy link
Member

lfu commented Aug 4, 2017

Changes LGTM 👍

@gmcculloug gmcculloug merged commit 47cf919 into ManageIQ:master Aug 4, 2017
@gmcculloug gmcculloug added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants