Added active provisions to quota count. #196
Conversation
|
@miq-bot assign @gmcculloug |
|
@billfitzgerald0120 Please review failing spec. |
billfitzgerald0120
force-pushed
the
used_new_active_provisions
branch
from
2960b8b
to
b3f5d99
Compare
|
Removed old spec which was causing travis to fail. |
|
@tinaafitz Please Review |
Modified used method to count active provisions for quota. Added log messages to method. https://bugzilla.redhat.com/show_bug.cgi?id=1456819 Log messages display counts and type of quota. Sample log messages below: <AEMethod used> Quota Used: {:cpu=>373, :memory=>922780434432, :vms=>141, :storage=>9111136632832, :provisioned_storage=>10033917067264} <AEMethod used> Quota active_provisions_by_tenant: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>44023414784, :provisioned_storage=>0} <AEMethod used> Quota Totals: {:cpu=>374, :memory=>923854176256, :vms=>142, :storage=>9155160047616, :provisioned_storage=>10033917067264} <AEMethod used> Quota Used: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>8589934592, :provisioned_storage=>9663676416} <AEMethod used> Quota active_provisions_by_group: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>44023414784, :provisioned_storage=>0} <AEMethod used> Quota Totals: {:cpu=>2, :memory=>2147483648, :vms=>2, :storage=>52613349376, :provisioned_storage=>9663676416} <AEMethod used> Quota Used: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>8589934592, :provisioned_storage=>9663676416} <AEMethod used> Quota active_provisions_by_owner: {:cpu=>0, :memory=>0, :vms=>0, :storage=>0, :provisioned_storage=>0} <AEMethod used> Quota Totals: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>8589934592, :provisioned_storage=>9663676416}
billfitzgerald0120
force-pushed
the
used_new_active_provisions
branch
from
b3f5d99
to
5d4c745
Compare
|
Checked commit billfitzgerald0120@5d4c745 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@billfitzgerald0120 This was refactored in #191, which is not in Fine branch. Should PR 191 be backported to Fine? If not, please create a separate PR for Fine branch. |
|
@billfitzgerald0120 Then, please create a PR for Fine branch. This PR can't be backported as is due to the refactoring. |
|
@simaishi We do need both of these back ported. More detail here: Thanks |
|
@billfitzgerald0120 please make sure all needed PRs are marked as |
…sions Added active provisions to quota count. (cherry picked from commit a38ebc9) https://bugzilla.redhat.com/show_bug.cgi?id=1489507
|
Fine backport details: |
|
@billfitzgerald0120 Can you take a look at Travis failure? There was a conflict backporting to Fine branch in https://github.com/ManageIQ/manageiq-content/pull/196/files#diff-9c5e8f4a07d3caa797737be3a823473eL22, so probably spec needs to be updated somewhere else? |
Updated method and test.
https://bugzilla.redhat.com/show_bug.cgi?id=1456819
Added log messages for counts and quota type.
Sample log messages below:
Quota Used: {:cpu=>373, :memory=>922780434432, :vms=>141, :storage=>9111136632832, :provisioned_storage=>10033917067264}
Quota active_provisions_by_tenant: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>44023414784, :provisioned_storage=>0}
Quota Totals: {:cpu=>374, :memory=>923854176256, :vms=>142, :storage=>9155160047616, :provisioned_storage=>10033917067264}
Quota Used: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>8589934592, :provisioned_storage=>9663676416}
Quota active_provisions_by_group: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>44023414784, :provisioned_storage=>0}
Quota Totals: {:cpu=>2, :memory=>2147483648, :vms=>2, :storage=>52613349376, :provisioned_storage=>9663676416}
Quota Used: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>8589934592, :provisioned_storage=>9663676416}
Quota active_provisions_by_owner: {:cpu=>0, :memory=>0, :vms=>0, :storage=>0, :provisioned_storage=>0}
Quota Totals: {:cpu=>1, :memory=>1073741824, :vms=>1, :storage=>8589934592, :provisioned_storage=>9663676416}
@miq-bot add_label bug, fine/yes