Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2v: Extend 'VM Transform' dialog to select VMs by tag #200

Merged
merged 8 commits into from
Oct 30, 2017
Merged

v2v: Extend 'VM Transform' dialog to select VMs by tag #200

merged 8 commits into from
Oct 30, 2017

Conversation

smelamud
Copy link
Contributor

@smelamud smelamud commented Oct 24, 2017 •
edited
Loading

Added tag category and tag name fields to the 'VM Transform' dialog to
be able to select VMs for V2V by tag. Hide these fields if the dialog is
open from VM details view. Hide VM name input field if the dialog is
open from VM list view. Start several V2V requests if several VMs are
selected by tag.

Depends on ManageIQ/manageiq-providers-ovirt#115
Depends on ManageIQ/manageiq-ui-classic#2501

@smelamud
v2v: Extend 'VM Transform' dialog to select VMs by tag
ee53f81 
Added tag category and tag name fields to the 'VM Transform' dialog to
be able to select VMs for V2V by tag. Hide these fields if the dialog is
open from VM details view. Hide VM name input field if the dialog is
open from VM list view. Start several V2V requests if several VMs are
selected by tag.
@smelamud
Fix comments by miq-bot
dbe86a1
@smelamud
Copy link
Contributor Author

@miq-bot assign gmcculloug

@gmcculloug gmcculloug mentioned this pull request Oct 25, 2017
Merged
@smelamud smelamud mentioned this pull request Oct 25, 2017
Merged
@smelamud
Copy link
Contributor Author

smelamud commented Oct 25, 2017 •
edited
Loading

False positive from miq-bot: find_by method does not exist in this class, find_by_name is used correctly.

@gmcculloug
Copy link
Member

@smelamud This PR is missing specs.

tinaafitz
tinaafitz suggested changes Oct 25, 2017
View reviewed changes
...te/ManageIQ/Infrastructure/VM/Transform/Import.class/__methods__/create_vm_import_request.rb Outdated
@@ -14,16 +14,36 @@ def initialize(handle = $evm)
end

def main
validate_root_args %w(vm dialog_name dialog_provider dialog_cluster dialog_storage dialog_sparse)
validate_root_args(%w(vm dialog_provider dialog_cluster dialog_storage dialog_sparse))
if [email protected]['dialog_tag_category'].empty? && [email protected]['dialog_tag_name'].empty?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smelamud Can we use @handle.root['dialog_tag_category'].present? && @handle.root['dialog_tag_name'].present?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinaafitz Done.

...te/ManageIQ/Infrastructure/VM/Transform/Import.class/__methods__/create_vm_import_request.rb Outdated
validate_root_args(%w(vm dialog_provider dialog_cluster dialog_storage dialog_sparse))
if [email protected]['dialog_tag_category'].empty? && [email protected]['dialog_tag_name'].empty?
tag = "/#{@handle.root['dialog_tag_category']}/#{@handle.root['dialog_tag_name']}"
tagged_vms = @handle.vmdb(:vm).find_tagged_with(:all => tag, :ns => '/managed')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smelamud Can we use the following to limit finding tagged VMWare VMs? $evm.vmdb('ManageIQ_Providers_Vmware_InfraManager_Vm').find_tagged_with(:all => tag, :ns => '/managed')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinaafitz It is limited to VMWare VMs only now. In future it may support other providers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smelamud I know the feature is limited to VMWare, but the vmdb find is not limited. Any Cloud/Infrastructure VM that contains that tag would be included here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinaafitz Done.

...te/ManageIQ/Infrastructure/VM/Transform/Import.class/__methods__/create_vm_import_request.rb Outdated
'Vm::vm' => @handle.root['vm'].id,
'name' => @handle.root['dialog_name'],
'Vm::vm' => vm.id,
'name' => target_name.empty? ? vm.name : target_name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use present? in place of empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinaafitz Done.

...utomate/ManageIQ/Infrastructure/VM/Transform/Import.class/__methods__/list_tag_categories.rb
@@ -0,0 +1,43 @@
module ManageIQ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a spec test for this method?

...ent/automate/ManageIQ/Infrastructure/VM/Transform/Import.class/__methods__/list_tag_names.rb
@@ -0,0 +1,47 @@
module ManageIQ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this method?

content/automate/ManageIQ/Infrastructure/VM/Transform/Import.class/__methods__/show_name.rb
@@ -0,0 +1,32 @@
module ManageIQ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needed here as well.

@smelamud
Copy link
Contributor Author

@gmcculloug @tinaafitz Can I add specs in another pull request? I'm working on them currently, but cannot guarantee to get them ready by evening.

tinaafitz
tinaafitz approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smelamud Changes look good.
@gmcculloug Please review.

@smelamud
Copy link
Contributor Author

@gmcculloug @tinaafitz Added specs.

@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commits smelamud/manageiq-content@ee53f81~...51ceff7 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
8 files checked, 2 offenses detected

content/automate/ManageIQ/Infrastructure/VM/Transform/Import.class/methods/list_tag_names.rb

spec/content/automate/ManageIQ/Infrastructure/VM/Transform/Import.class/methods/list_tag_names_spec.rb

@jelkosz
Copy link
Contributor

jelkosz commented Oct 30, 2017

This warning are false.

@gmcculloug
Copy link
Member

To clarify, the warnings are false because the Classification model exposes a find_by_name method which is not the default active record method. So the warning can be safely ignored.

@gmcculloug gmcculloug merged commit 5ff07dd into ManageIQ:master Oct 30, 2017
@gmcculloug gmcculloug added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smelamud @gmcculloug @miq-bot @jelkosz @tinaafitz