-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in the manageiq.* automate and vmdb roles #254
Conversation
@miq-bot add_label wip, enhancement cc - @gmcculloug, @gtanzillo |
2fa953a
to
8632434
Compare
@miq-bot remove_label wip |
cb9d1c3
to
cb9277c
Compare
TODO: Write tests, ruggedize this, make sure role activation run this and make sure it works 😅 All of this depends on: https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096 ManageIQ/manageiq-content#254
TODO: Write tests, ruggedize this, make sure role activation run this and make sure it works 😅 All of this depends on: https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096 ManageIQ/manageiq-content#254
@Fryguy I think this is ready to merge. Any remaining issues? |
TODO: Write tests, ruggedize this, make sure role activation run this and make sure it works 😅 All of this depends on: https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096 ManageIQ/manageiq-content#254
TODO: Write tests, ruggedize this, make sure role activation run this and make sure it works 😅 All of this depends on: https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096 ManageIQ/manageiq-content#254
TODO: Write tests, add RFE/BZ links when tests are written All of this depends on: https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096 ManageIQ/manageiq-content#254
@Fryguy it appears this can be merged. Can you review. |
@gmcculloug @syncrou can you drop the WIP from the description of this PR if it's ready? |
@jrafanie - I pulled out the WIP statement. |
@miq-bot add_label blocker |
Looks good. Since we are adding a lot of yaml here, it might be good to add the yamllint stuff so that the bot can verify it for us. This way, you don't get churn on your yamls, but I'll leave it up to @gmcculloug on how to proceed, since I know you want this is sooner than later. |
@Fryguy Can you point to an example of what is required for yamllint? Depending on the level of effort it could be a follow PR. |
@syncrou can you add the garpindashvili/yes label. |
@miq-bot add_label garpindashvili/yes |
@syncrou Cannot apply the following label because they are not recognized: garpindashvili/yes |
@imtayadeway Can you comment on #254 (comment) ? |
@gmcculloug Yes, it can be follow up PR. I'm mostly concerned about the churn, which can be distracting in the future, but it's up to you. |
38c1d03
to
db3dba5
Compare
@gmcculloug I attempted to answer your question in the form of a PR: #277 |
@Fryguy - Everything we discussed for this PR is taken care of. |
The bot hasn't rerun on this repo, so it hasn't really used the yamllint stuff. The only way to force it is to push a commit (just amend the commit and force push). |
6ac8e27
to
01cc960
Compare
01cc960
to
d6fd182
Compare
Checked commit syncrou@d6fd182 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@Fryguy - Made a couple of changes suggested by the new yamllint rules. Everything is green now again. |
Add in the miq. automate and vmdb roles (cherry picked from commit e045e8c) https://bugzilla.redhat.com/show_bug.cgi?id=1566658
Gaprindashvili backport details:
|
Note: Updated the PR title and description to match the changes that were made and mentioned in these comments: |
The roles have been namespaced via the
manageiq
prefix:manageiq.manageiq-automate
andmanageiq.manageiq-vmdb
.https://bugzilla.redhat.com/show_bug.cgi?id=1539762
Edit by @NickLaMuro : Updated the description and title to reflect the actual prefix that was commited per this comment: #254 (comment)