Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changes for service, vm retire request approval #272

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Add changes for service, vm retire request approval #272

merged 1 commit into from
Apr 3, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Apr 2, 2018

This PR adds the manageiq domain changes necessary for cloud and infra vms and services to do autoapproval for retirement as a request.

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 2, 2018

@tinaafitz can you 👀 for me please

@miq-bot miq-bot added the wip label Apr 2, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 2, 2018 •
edited
Loading

this has request starting and request created for vms:
System/Policy.class/vmretirerequest_starting.yaml
System/Policy.class/vmretirerequest_created.yaml

@tinaafitz shouldn't the policy changes for services also have request starting and request created?

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 2, 2018

@miq-bot add_label enhancement

tinaafitz
tinaafitz reviewed Apr 2, 2018
View reviewed changes
content/automate/ManageIQ/System/Policy.class/vmretirerequest_created.yaml Outdated
description:
fields:
- rel6:
value: "/Infrastructure/${/#miq_request.resource.ci_type}/Retirement/StateMachines/RetirementRequestApproval/Default"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Since this instance will be used for cloud and infra, should the first part of the value be the substituted value from parse_provider_category?

@tinaafitz
Copy link
Member

@d-m-u Can you add screen shots for the 3 new approval classes?

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 3, 2018

screen shot 2018-04-03 at 9 22 07 am
screen shot 2018-04-03 at 9 21 45 am
screen shot 2018-04-03 at 9 21 29 am

@d-m-u d-m-u changed the title [WIP] Add changes for service, vm retire request approval Add changes for service, vm retire request approval Apr 3, 2018
@miq-bot miq-bot removed the wip label Apr 3, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2018

Checked commit d-m-u@6efac04 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
28 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

tinaafitz
tinaafitz approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Looks good.
@gmcculloug Please review.

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 3, 2018

@miq-bot add_label retirement

@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2018

@d-m-u Cannot apply the following label because they are not recognized: retirement

@gmcculloug gmcculloug self-assigned this Apr 3, 2018
@gmcculloug gmcculloug merged commit 995e7cb into ManageIQ:master Apr 3, 2018
@gmcculloug gmcculloug added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 3, 2018
@d-m-u d-m-u deleted the request_approval branch April 3, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @tinaafitz @miq-bot @gmcculloug