Tag migrated VM.

[lfu]

Part of ManageIQ/manageiq#17389.

https://bugzilla.redhat.com/show_bug.cgi?id=1565199

[lfu]

@miq-bot add_label enhancement, transformation

[gmcculloug]

@fdupont-redhat Please review/test

[ghost]

Currently, the code exits right at the beginning of main. If we want the tag assignment to be active, the exit MIQ_OK statement should be placed after source_vm.tag_with(...).

[gmcculloug]

To take this a step further it would be better to remove the exit MIQ_OK line completely and change this method to only do the tagging.

The other logic should either be removed or at the least moved into a new method in this script.

@fdupont-redhat Are there plans to use this logic soon? If not let's remove the unused code.

cc @mkanoor

[ghost]

@gmcculloug, no plan to change it soon, so yes it can be remove. It will be cleaner.

[miq-bot]

Checked commit lfu@79dfbbe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[gmcculloug]

@fdupont-redhat Don't want to lose the question from the hidden comment #324 (comment)

@fdupont-redhat Are there plans to use this logic soon? If not let's remove the unused code.

[ghost]

@gmcculloug, no plan to change it soon, so yes it can be removed, or simply moved in a dedicated method. It will be cleaner.

…

On 6 June 2018 at 18:49, Greg McCullough ***@***.***> wrote: @fdupont-redhat <https://github.com/fdupont-redhat> Don't want to lose the question from the hidden comment #324 (comment) <#324 (comment)> @fdupont-redhat <https://github.com/fdupont-redhat> Are there plans to use this logic soon? If not let's remove the unused code. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#324 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYoAaEkMGC12jpou2JbN3a_vSG9_uTMIks5t6AgbgaJpZM4UcnXJ> .

-- *Fabien Dupont* PRINCIPAL SOFTWARE ENGINEER Red Hat - Solutions Engineering [email protected] M: +33 (0) 662 784 971 <+33662784971> <http://redhat.com> *TRIED. TESTED. TRUSTED.* Twitter: @redhatway <https://twitter.com/redhatway> | Instagram: @redhatinc <https://www.instagram.com/redhatinc/> | Snapchat: @redhatsnaps

[ghost]

@gmcculloug, no plan to change it soon, so yes it can be remove. It will be cleaner.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 9065f2754cb1b97a12709ce2624b0bec5dd5d29a
Author: Greg McCullough <[email protected]>
Date:   Tue Jun 12 08:59:12 2018 -0400

    Merge pull request #324 from lfu/migrated_policy_1565199
    
    Tag migrated VM.
    (cherry picked from commit d7d3f5d13e8326c9b2ceab1f59df5de58130d903)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1590430