Requested Quota for instance_type dialog override. #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated requested method to allow for Service dialogs to override instance_type for cloud provisioning. Added tests for Google service and instance_type override This requires updated quota_helper method in ManageIQ repo.
|
@miq-bot add_label enhancement |
|
Checked commit billfitzgerald0120@641b8d0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
billfitzgerald0120
changed the title
|
@tinaafitz Please review |
tinaafitz
approved these changes
Jun 18, 2018
mkanoor
reviewed
Jun 18, 2018
| @@ -263,7 +264,7 @@ def cloud_storage(args_hash) | |||
| flavor.root_disk_size.to_i + flavor.ephemeral_disk_size.to_i + flavor.swap_disk_size.to_i | |||
| end | |||
|
|
|||
| storage += cloud_volume_storage(args_hash) | |||
| storage += cloud_volume_storage(args_hash) if @reconfigure_request | |||
There was a problem hiding this comment.
@billfitzgerald0120
Is this related to this PR? or related to configure request
There was a problem hiding this comment.
@mkanoor I added the "if @reconfigure_request" because it caused the test to fail without it.
|
@mkanoor The dependent PR is merged, anything else for this PR? |
mkanoor
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated requested method to allow for Service dialogs to override instance_type for cloud provisioning.
Added tests for Google service and instance_type override.
This requires updated quota_helper method in ManageIQ repo.
ManageIQ/manageiq#17597
https://bugzilla.redhat.com/show_bug.cgi?id=1581288