Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation of currently running conversions by host #358

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2018

The number of currently running conversions per host was based on task option named transformation_host which doesn't exist. We only store the transformation host id and name, as it is thinner than storing the host object. However, the method was not updated after this change.

The PR also sets the default max number of conversions per host to 10, which is the recommendation of oVirt.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1600152

…ault max number of conversions per host to 10.
@ghost
Copy link
Author

ghost commented Jul 11, 2018

@miq-bot add-label transformation

@ghost ghost changed the title Fix computation of currently running conversions by host [WIP] Fix computation of currently running conversions by host Jul 11, 2018
@ghost
Copy link
Author

ghost commented Jul 11, 2018

@miq-bot add-label bug

@miq-bot
Copy link
Member

miq-bot commented Jul 13, 2018

Checked commits fabiendupont/manageiq-content@9fe820e~...9a6de52 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gmcculloug gmcculloug added blocker and removed wip labels Jul 17, 2018
@gmcculloug gmcculloug changed the title [WIP] Fix computation of currently running conversions by host Fix computation of currently running conversions by host Jul 17, 2018
@gmcculloug gmcculloug merged commit 5ec8138 into ManageIQ:master Jul 17, 2018
@gmcculloug gmcculloug added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 17, 2018
simaishi pushed a commit that referenced this pull request Jul 31, 2018
…st_acquisition

Fix computation of currently running conversions by host
(cherry picked from commit 5ec8138)

https://bugzilla.redhat.com/show_bug.cgi?id=1600152
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 80623ba43ec9a1c78323f4649861297a1593ba95
Author: Greg McCullough <[email protected]>
Date:   Tue Jul 17 11:58:31 2018 -0400

    Merge pull request #358 from fdupont-redhat/v2v_fix_transformation_host_acquisition
    
    Fix computation of currently running conversions by host
    (cherry picked from commit 5ec8138d45278d3cda4ef9c95b244b8ac30ec9fb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1600152

@ghost ghost deleted the v2v_fix_transformation_host_acquisition branch July 31, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants