-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix computation of currently running conversions by host #358
Fix computation of currently running conversions by host #358
Conversation
…ault max number of conversions per host to 10.
@miq-bot add-label transformation |
@miq-bot add-label bug |
Checked commits fabiendupont/manageiq-content@9fe820e~...9a6de52 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…st_acquisition Fix computation of currently running conversions by host (cherry picked from commit 5ec8138) https://bugzilla.redhat.com/show_bug.cgi?id=1600152
Gaprindashvili backport details:
|
The number of currently running conversions per host was based on task option named
transformation_host
which doesn't exist. We only store the transformation host id and name, as it is thinner than storing the host object. However, the method was not updated after this change.The PR also sets the default max number of conversions per host to 10, which is the recommendation of oVirt.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1600152