Use targeted refresh during transformation #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
reviewed
Jul 30, 2018
| @@ -16,27 +16,13 @@ def main | |||
| destination_vm = ManageIQ::Automate::Transformation::Infrastructure::VM::RedHat::Utils.new(destination_ems).vm_find_by_name(source_vm.name) | |||
| raise "VM #{source_vm.name} not found in destination provider #{destination_ems.name}" if destination_vm.nil? | |||
|
|
|||
| finished = false | |||
|
|
|||
| destination_vm_vmdb = @handle.vmdb(:vm).where(["ems_ref = ?", destination_vm.href.gsub(/^\/ovirt-engine/, '')]).first | |||
There was a problem hiding this comment.
Realize this is outside of the changes in this PR but future refactorings should be:
destination_vm_vmdb = @handle.vmdb(:vm).find_by(:ems_ref => destination_vm.href.gsub(/^\/ovirt-engine/, ''))There was a problem hiding this comment.
Changed. I suppose it has better performance.
gmcculloug
changed the title
|
Checked commits fabiendupont/manageiq-content@c8cfa2c~...7be7554 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Jul 31, 2018
Use targeted refresh during transformation (cherry picked from commit 4a91827) https://bugzilla.redhat.com/show_bug.cgi?id=1610550
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, during transformation, we triggered a full refresh to be sure that the VM was in the inventory for the post migration steps. But, this consumed a lot of resources compared to the single VM we want to track. And on a huge inventory with thousands of VMs, triggering a full refresh for each migration can soon be problematic.
This PR adds a new instance in the event switchboard that triggers a targeted refresh for the associated VM. The event is named
VM_IMPORT_FROM_CONFIGURATION_EXECUTED_SUCCESSFULLY.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1607368