Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore VM ownership and retirement when migrating #397

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2018

When a virtual machine is migrated (v2v), the ownership and retirement data are not propagated to the destination VM. This PR implements this feature.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1615141

@ghost ghost force-pushed the v2v_preserve_ownership_and_retirement_date branch from 69a1d6a to c9e1771 Compare August 13, 2018 07:44
@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2018

Checked commits fabiendupont/manageiq-content@c9e1771~...831fb82 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@ghost
Copy link
Author

ghost commented Aug 13, 2018

@miq-bot add-labels transformation, enhancement, gaprindashvili/yes, blocker

@gmcculloug gmcculloug self-assigned this Aug 13, 2018
@gmcculloug gmcculloug merged commit 836d63c into ManageIQ:master Aug 13, 2018
@gmcculloug gmcculloug added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 13, 2018
@ghost ghost deleted the v2v_preserve_ownership_and_retirement_date branch August 14, 2018 16:00
@simaishi
Copy link
Contributor

@fdupont-redhat Looks like this PR is built on top of #385, but currently there is no plan to backport PR 385 to Gaprindashvili branch. (I could have backported PR 385 if it was just spec only changes as the PR says, but the PR actually modifies the production code as well as adding specs. In which case, I have to have a blocker BZ targeted for the next G-release to backport).

Can you create a separate PR for Gaprindashvili branch?

simaishi pushed a commit that referenced this pull request Sep 19, 2018
…d_retirement_date

Restore VM ownership and retirement when migrating
(cherry picked from commit 836d63c)

https://bugzilla.redhat.com/show_bug.cgi?id=1618807
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d104748ae4e546a90d5197ecda8af9b16b10e6af
Author: Greg McCullough <[email protected]>
Date:   Mon Aug 13 17:43:58 2018 -0400

    Merge pull request #397 from fdupont-redhat/v2v_preserve_ownership_and_retirement_date
    
    Restore VM ownership and retirement when migrating
    (cherry picked from commit 836d63c89816fa8d1cf57c3ea6974e46f7a34c2a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1618807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants