-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix request denial #471
Fix request denial #471
Conversation
Pull Request Test Coverage Report for Build 2340
💛 - Coveralls |
@@ -2,4 +2,4 @@ | |||
message = $evm.object['reason'] | |||
$evm.log('info', "Request denied because of #{message}") | |||
request.message = message | |||
request.deny('admin', msg = message) | |||
request.deny('admin', message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fdupont-redhat I do not see how this would do anything more than assign an unused variable msg
. The result of the assignment msg = message
would return the content of the message
variable and passed that as the second parameter to the deny
method.
While this is a reasonable cleanup I am concerned that this is not actually fixing any bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmcculloug You're completely right. Going too fast. The problem is more likely the name of the method in deny_request.yml... Fixed in my appliance in an overlay domain, but not in ManageIQ. My bad.
Checked commits fabiendupont/manageiq-content@f3af74a~...1c6b40c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Fix request denial (cherry picked from commit 4e2e229) https://bugzilla.redhat.com/show_bug.cgi?id=1640816
Hammer backport details:
|
When denying the request, the method call is wrong. This PR fixes it.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1640816