[V2V] Allow a retry to let virt-v2v start #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label transformation, enhancement, hammer/yes, blocker |
|
Checked commit fabiendupont@27bfa74 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
reviewed
Dec 4, 2018
| @@ -44,8 +44,12 @@ def main | |||
| @handle.set_state_var(:ae_state_progress, 'message' => 'Disks transformation succeeded.', 'percent' => 100) | |||
| end | |||
| rescue => e | |||
| @handle.set_state_var(:ae_state_progress, 'message' => e.message) | |||
| raise | |||
| if @handle.root['ae_state_retries'] > 1 | |||
There was a problem hiding this comment.
@fdupont-redhat Are their specific exceptions that we should catch or is it that the first exception is always caught and ignored and along the way we suppress the exception which will never get raised.
There was a problem hiding this comment.
@mkanoor The exception will be raised again if it's legit, meaning that it actually failed. If it was only because virt-v2v-wrapper has not created the state file, a retry should be enough.
tinaafitz
approved these changes
Dec 4, 2018
mkanoor
approved these changes
Dec 4, 2018
simaishi
pushed a commit
that referenced
this pull request
Dec 10, 2018
…sformation_check [V2V] Allow a retry to let virt-v2v start (cherry picked from commit 7e6c26d) https://bugzilla.redhat.com/show_bug.cgi?id=1653407
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In slow environments, virt-v2v-wrapper may need a few seconds to start virt-v2v and to create the state file. This can lead the transformation check to fail because the file doesn't exist. With this PR, we allow a retry of VMCheckTransformed, i.e. 1 minute, to let virt-v2v-wrapper start the conversion and create the state file.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1653407