use :automation_manager_ansible_tower instead of :automation_manager

[jameswnl]

Corresponding to the refactoring of factories in ManageIQ/manageiq#19330

[jameswnl]

@jrafanie @d-m-u check this out

[d-m-u]

I don't think this is the right way to do this. Fiiiiine. But also, LJ's right. Please see the work done in ManageIQ/manageiq#18842 for https://bugzilla.redhat.com/show_bug.cgi?id=1671844. The factory shouldn't be an intermediate class.

[coveralls]

Pull Request Test Coverage Report for Build 3652

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+5.6%) to 96.795%

---

Totals
Change from base Build 3644:	5.6%
Covered Lines:	2748
Relevant Lines:	2839

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 3652

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+5.6%) to 96.795%

---

Totals
Change from base Build 3644:	5.6%
Covered Lines:	2748
Relevant Lines:	2839

---

💛 - Coveralls

[miq-bot]

Checked commit jameswnl@8887d60 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 0 offenses detected
Everything looks fine. 👍

[jrafanie]

@d-m-u what do you think? These might have been using an automation manager but the tests are clearly using an ansible tower automation manager. I think this makes sense to use the provider names here since that's what being tested.

[d-m-u]

Then how are we addressing the current issue with the validation in the main repo? I'm fine with this if that gets addressed as well, but it feels problematic to have a single intermediate factory.

[kbrock]

If the test are about tower - then the test should point to a tower factory

[d-m-u]

I don't disagree, but https://github.com/ManageIQ/manageiq/pull/19330/files#diff-4fe1bbb18a78426d823d817a71f11ae6R116 is still going to bite us.

[jrafanie]

I don't think this is the right way to do this. Please see the work done in ManageIQ/manageiq#18842 for https://bugzilla.redhat.com/show_bug.cgi?id=1671844. The factory shouldn't be an intermediate class.

I think we agree. For this specific set of tests, they seem to be testing tower automation manager so the change in this PR looks right the right thing to do.

We'll need to fix the base factory as referenced above in a different PR as it's not usable right now.