Refactor start_retirement method for Infra VM Retirement. #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3887
💛 - Coveralls |
lfu
reviewed
Nov 12, 2019
| allow(ae_service).to receive(:create_notification) | ||
| expect(ae_service).to receive(:create_notification).with(:type => :vm_retiring, :subject => svc_vm) | ||
| expect(svc_vm).to receive(:start_retirement) | ||
| expect { described_class.new(ae_service).main }.to_not raise_error |
There was a problem hiding this comment.
@billfitzgerald0120 Can you make the same change here to check retirement_state?
There was a problem hiding this comment.
I updated the spec as you requested
billfitzgerald0120
force-pushed
the
refactor_infra_vm_retirement_start_retirement
branch
from
92ec56a
to
79d3e6b
Compare
lfu
approved these changes
Nov 13, 2019
This PR is based on the issue below. ManageIQ/manageiq#12038 @miq-bot add_label refactoring @miq-bot assign @tinaafitz Added test for retirement_start eq retiring as requested Change method to add vm as a method
billfitzgerald0120
force-pushed
the
refactor_infra_vm_retirement_start_retirement
branch
from
79d3e6b
to
3d63718
Compare
|
Checked commit billfitzgerald0120@3d63718 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lfu I changed the method to be better. Can you review again ? Thank you |
lfu
approved these changes
Nov 14, 2019
tinaafitz
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the issue below.
ManageIQ/manageiq#12038
@miq-bot add_label refactoring
@miq-bot assign @tinaafitz