Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use automate timeout when execution_ttl is not set for an orchestration service #618

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Use automate timeout when execution_ttl is not set for an orchestration service #618

merged 1 commit into from
Jan 6, 2020

Conversation

lfu
Copy link
Member

@lfu lfu commented Dec 16, 2019 •
edited
Loading

Part of ManageIQ/manageiq#19649.
Related to ManageIQ/manageiq#19558

https://bugzilla.redhat.com/show_bug.cgi?id=1781353

@miq_bot assign @tinaafitz
@miq_bot add_label enhancement, changelog/yes, orchestration

@lfu lfu mentioned this pull request Dec 16, 2019
Merged
@coveralls
Copy link

coveralls commented Dec 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 4012

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.267%
Totals Coverage Status
Change from base Build 4010: 0.01%
Covered Lines: 3025
Relevant Lines: 3110
💛 - Coveralls

@lfu lfu changed the title Use automate timeout when execution_ttl is not set for an orchestration service [WIP] Use automate timeout when execution_ttl is not set for an orchestration service Dec 16, 2019
@lfu lfu force-pushed the automate_timeout_orchestration_service_1781353 branch from 85565c8 to d9a54fd Compare December 17, 2019 15:09
@miq-bot
Copy link
Member

miq-bot commented Dec 17, 2019

Checked commit lfu@d9a54fd with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

@lfu lfu changed the title [WIP] Use automate timeout when execution_ttl is not set for an orchestration service Use automate timeout when execution_ttl is not set for an orchestration service Dec 17, 2019
@lfu
Copy link
Member Author

lfu commented Dec 17, 2019

@miq-bot remove_label wip, unmergeable

@tinaafitz tinaafitz merged commit 73cf178 into ManageIQ:master Jan 6, 2020
@tinaafitz tinaafitz added this to the Sprint 127 Ending Jan 6, 2020 milestone Jan 6, 2020
@lfu
Copy link
Member Author

lfu commented Jan 22, 2020

@miq-bot add_label ivanchuk/yes

simaishi pushed a commit that referenced this pull request Jan 24, 2020
@tinaafitz @simaishi
Merge pull request #618 from lfu/automate_timeout_orchestration_servi…
7f63038 
…ce_1781353

Use automate timeout when execution_ttl is not set for an orchestration service

(cherry picked from commit 73cf178)

https://bugzilla.redhat.com/show_bug.cgi?id=1794752
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 7f630388eb891a893818ca424576c17447868c90
Author: tina <[email protected]>
Date:   Mon Jan 6 14:21:46 2020 -0500

    Merge pull request #618 from lfu/automate_timeout_orchestration_service_1781353

    Use automate timeout when execution_ttl is not set for an orchestration service

    (cherry picked from commit 73cf178d5f59d72a6ec87dcaa103a9f7a3f37d67)

    https://bugzilla.redhat.com/show_bug.cgi?id=1794752

lfu added a commit to lfu/manageiq-content that referenced this pull request Jan 29, 2020
@lfu
Save automate timeout in to a service options hash.
8ad8e85 
Followup of ManageIQ#618

https://bugzilla.redhat.com/show_bug.cgi?id=1781353
@lfu lfu mentioned this pull request Jan 29, 2020
Merged
@lfu lfu deleted the automate_timeout_orchestration_service_1781353 branch May 28, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

@mkanoor mkanoor mkanoor approved these changes

Assignees

@tinaafitz tinaafitz

Labels
changelog/yes enhancement ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lfu @coveralls @miq-bot @simaishi @tinaafitz @mkanoor @gmcculloug