-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an automate event for DrsMigrateVM_Task #625
Add an automate event for DrsMigrateVM_Task #625
Conversation
This adds an automate event instance for the DrsMigrateVM_Task event which is a more specific subclass of the MigrateVM_Task class. https://bugzilla.redhat.com/show_bug.cgi?id=1788540
Checked commit agrare@fbca988 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Pull Request Test Coverage Report for Build 4095
💛 - Coveralls |
We could either add @gmcculloug which way would be better? |
So I went with this because it mirrors the MigrateVM_Task behavior, I thought it'd be confusing if things were different between a manual migration and an automated DRS migration. |
@agrare Sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should keep it similar to the MigrateVM_Task
event. I think this way would allow for the ability to cancel the task from policy if needed. Users could always override this and the DrsMigrateVM_Task_Complete
event if they really needed to switch the logic.
Thanks @gmcculloug , I'll leave it up to you if you think this is enough to consider the BZ "fixed" |
@agrare @gmcculloug can this be |
Add an automate event for DrsMigrateVM_Task (cherry picked from commit 1196ecc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1794573
Hammer backport details:
|
Add an automate event for DrsMigrateVM_Task (cherry picked from commit 1196ecc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1794574
Ivanchuk backport details:
|
This adds an automate event instance for the DrsMigrateVM_Task event
which is a more specific subclass of the MigrateVM_Task class.
https://bugzilla.redhat.com/show_bug.cgi?id=1788540