Refactor microsoft_best_fit_least_utilized method for VM Placement. #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billfitzgerald0120
changed the title
Pull Request Test Coverage Report for Build 4098
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4134
💛 - Coveralls |
lfu
reviewed
Jan 13, 2020
...rastructure/VM/Provisioning/Placement.class/__methods__/microsoft_best_fit_least_utilized.rb
Show resolved
Hide resolved
lfu
reviewed
Jan 13, 2020
...rastructure/VM/Provisioning/Placement.class/__methods__/microsoft_best_fit_least_utilized.rb
Outdated
Show resolved
Hide resolved
billfitzgerald0120
force-pushed
the
refactor_microsoft_best_fit_least_utilized
branch
from
468c42b
to
30285a1
Compare
lfu
reviewed
Jan 16, 2020
...rastructure/VM/Provisioning/Placement.class/__methods__/microsoft_best_fit_least_utilized.rb
Outdated
Show resolved
Hide resolved
…ent. Refactored method and test. Removed old test. This PR is based on the issue below. ManageIQ/manageiq#12038 @miq-bot add_label refactoring @miq-bot assign @tinaafitz Added check for ems Removed storage profile as requested Changed ems logic in method as requested
billfitzgerald0120
force-pushed
the
refactor_microsoft_best_fit_least_utilized
branch
from
30285a1
to
6ace6e1
Compare
|
Some comments on commit billfitzgerald0120@6ace6e1 spec/content/automate/ManageIQ/Infrastructure/VM/Provisioning/Placement.class/methods/microsoft_best_fit_least_utilized_spec.rb
|
|
Checked commit billfitzgerald0120@6ace6e1 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
billfitzgerald0120
changed the title
|
@lfu Looks like your review comments were addressed. Anything else on this one or is it ready to merge? |
lfu
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored method and test.
Removed old test.
This PR is based on the issue below.
ManageIQ/manageiq#12038
@miq-bot add_label refactoring
@miq-bot assign @tinaafitz