Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all deprecated email components from Cloud namespace. #641

Merged

Conversation

billfitzgerald0120
Copy link
Contributor

Removed class and all instances and methods from 5 classes:

Cloud/Orchestration/Provisioning/Email
Cloud/Orchestration/Reconfigure/Email
Cloud/Orchestration/Retirement/Email

Cloud/VM/Provisioning/Email
Cloud/VM/Retirement/Email

Email is now in System/Notification/Email class.

@miq-bot add_label hammer/no, ivanchuk/no, changelog/yes, technical debt
Removed vm_retire_extend_spec.rb

… class and all instances and methods from 4 classes:

Cloud/Orchestration/Provisioning/Email
Cloud/Orchestration/Reconfigure/Email
Cloud/Orchestration/Retirement/Email

Cloud/VM/Provisioning/Email
Cloud/VM/Retirement/Email

Email is now in System/Notification/Email class.

@miq-bot add_label hammer/no, ivanchuk/no, changelog/yes, technical debt
Removed vm_retire_extend_spec.rb
@miq-bot
Copy link
Member

miq-bot commented Feb 24, 2020

Checked commit billfitzgerald0120@26f28bc with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@coveralls
Copy link

coveralls commented Feb 24, 2020

Pull Request Test Coverage Report for Build 4290

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 97.451%

Totals Coverage Status
Change from base Build 4224: -0.009%
Covered Lines: 3058
Relevant Lines: 3138

💛 - Coveralls

@tinaafitz tinaafitz merged commit 1e59d0b into ManageIQ:master Feb 28, 2020
@tinaafitz tinaafitz added this to the Sprint 131 Ending Mar 2, 2020 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants