-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LenovoXclarity Namespace to EMS Events into Automate #77
Conversation
@lfu Please review |
attributes: | ||
description: | ||
display_name: | ||
name: LenovoXclarity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Event class name should match what is defined by ems_event.source
in event parser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I'm doing another PR with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you can't fix it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only way would be adding dependency to this PR because they are different projects, content and core. Have any way to add the change into event parser here?
Have you followed the steps in Creating a Pull Request for enhancements to ManageIQ Automate Domain? to ensure the yaml file format? |
@lfu I followed step by step. |
@AndreyMenezes Please squash the two commits into one. It is weird that you add a file in the first commit then remove it in the second commit. |
@lfu This is referring to the file you requested to remove in when we talk at gitter. Do you prefer to close this PR and I open another without this file? |
Checked commit AndreyMenezes@c598807 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
LGTM 👍 |
@AndreyMenezes Please reference this PR in your followup work for the event |
Added LenovoXclarity Domain to EMS Events into Automate (cherry picked from commit 3c3ff95)
Fine backport details:
|
Create a LenovoXclarity class and missing instance for the Lenovo's Domain.