Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LenovoXclarity Namespace to EMS Events into Automate #77

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

AndreyMenezes
Copy link
Member

Create a LenovoXclarity class and missing instance for the Lenovo's Domain.

@gmcculloug gmcculloug self-assigned this Mar 27, 2017
@gmcculloug
Copy link
Member

@lfu Please review

attributes:
description:
display_name:
name: LenovoXclarity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event class name should match what is defined by ems_event.source in event parser.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I'm doing another PR with this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you can't fix it here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only way would be adding dependency to this PR because they are different projects, content and core. Have any way to add the change into event parser here?

@lfu
Copy link
Member

lfu commented Mar 27, 2017

Have you followed the steps in Creating a Pull Request for enhancements to ManageIQ Automate Domain? to ensure the yaml file format?

@AndreyMenezes
Copy link
Member Author

@lfu I followed step by step.

@lfu
Copy link
Member

lfu commented Mar 28, 2017

@AndreyMenezes Please squash the two commits into one. It is weird that you add a file in the first commit then remove it in the second commit.

@AndreyMenezes
Copy link
Member Author

@lfu This is referring to the file you requested to remove in when we talk at gitter. Do you prefer to close this PR and I open another without this file?

@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

Checked commit AndreyMenezes@c598807 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

@lfu
Copy link
Member

lfu commented Mar 28, 2017

LGTM 👍

@gmcculloug
Copy link
Member

@AndreyMenezes Please reference this PR in your followup work for the event :source change so they get linked. Thanks.

@gmcculloug gmcculloug merged commit 3c3ff95 into ManageIQ:master Mar 29, 2017
@gmcculloug gmcculloug added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 29, 2017
simaishi pushed a commit that referenced this pull request Mar 30, 2017
Added LenovoXclarity Domain to EMS Events into Automate
(cherry picked from commit 3c3ff95)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 05098650ab27a2ee0471d20f25d04fa9b342d4c5
Author: Greg McCullough <[email protected]>
Date:   Wed Mar 29 16:21:01 2017 -0400

    Merge pull request #77 from AndreyMenezes/XCS-113
    
    Added LenovoXclarity Domain to EMS Events into Automate
    (cherry picked from commit 3c3ff9531045957e30eaf54c452e577924da86ae)

@gmcculloug gmcculloug changed the title Added LenovoXclarity Domain to EMS Events into Automate Added LenovoXclarity Namespace to EMS Events into Automate Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants